chore: Move to NcButton and add aria-label

Signed-off-by: Julius Knorr <[email protected]>
nextcloud · Jan 16, 2025 · 3f7c343 · 3f7c343
1 parent 09d787c
commit 3f7c343
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 18 deletions.
diff --git a/src/components/Editor/SmartPickerMenu.vue b/src/components/Editor/SmartPickerMenu.vue
@@ -5,26 +5,23 @@
 
 <template>
 	<div contenteditable="false" class="smart-picker-menu-container">
-		<NcActions :title="t('text', 'Open the Smart Picker')" :type="'tertiary'">
-			<NcActionButton @click="$emit('open-smart-picker')">
-				<template #icon>
-					<PlusIcon />
-				</template>
-			</NcActionButton>
-		</NcActions>
+		<NcButton :aria-label="t('text', 'Open the Smart Picker')" :type="'tertiary'" @click="$emit('open-smart-picker')">
+			<template #icon>
+				<PlusIcon />
+			</template>
+		</NcButton>
 	</div>
 </template>
 
 <script>
 import PlusIcon from 'vue-material-design-icons/Plus.vue'
-import { NcActions, NcActionButton } from '@nextcloud/vue'
+import { NcButton } from '@nextcloud/vue'
 
 export default {
 	name: 'SmartPickerMenu',
 	components: {
 		PlusIcon,
-		NcActions,
-		NcActionButton,
+		NcButton,
 	},
 }
 

diff --git a/src/plugins/currentLineMenu.js b/src/plugins/currentLineMenu.js
@@ -131,7 +131,7 @@ function currentParagraphDecorations(doc, currentParagraph, editor) {
  */
 function decorationForCurrentParagraph(currentParagraph, editor) {
 	return Decoration.widget(
-		currentParagraph.pos + 1,
+		currentParagraph?.pos + 1,
 		menuForCurrentParagraph(editor),
 		{ side: -1 },
 	)

diff --git a/src/tests/plugins/extractLinkParagraphs.spec.js b/src/tests/plugins/extractLinkParagraphs.spec.js
@@ -23,15 +23,15 @@ describe('extractLinkParagraphs', () => {
 		const doc = prepareDoc(content)
 		const paragraphs = extractLinkParagraphs(doc)
 		expect(paragraphs).toEqual([
-			{ offset: 0, type: 'text-only', nodeSize: 6 },
+			{ pos: 0, type: 'text-only', nodeSize: 6 },
 		])
 	})
 
 	it('returns paragraphs with a single preview', () => {
 		const doc = prepareDoc(preview)
 		const paragraphs = extractLinkParagraphs(doc)
 		expect(paragraphs).toEqual([
-			{ offset: 0, type: 'link-preview', nodeSize: 6 },
+			{ pos: 0, type: 'link-preview', nodeSize: 6 },
 		])
 	})
 
@@ -40,7 +40,7 @@ describe('extractLinkParagraphs', () => {
 		const doc = prepareDoc(content)
 		const paragraphs = extractLinkParagraphs(doc)
 		expect(paragraphs).toEqual([
-			{ offset: 0, type: 'text-only', nodeSize: 7 },
+			{ pos: 0, type: 'text-only', nodeSize: 7 },
 		])
 	})
 
@@ -50,8 +50,8 @@ describe('extractLinkParagraphs', () => {
 		const doc = prepareDoc(content)
 		const paragraphs = extractLinkParagraphs(doc)
 		expect(paragraphs).toEqual([
-			{ offset: 0, type: 'text-only', nodeSize: 6 },
-			{ offset: 6, type: 'text-only', nodeSize: 6 },
+			{ pos: 0, type: 'text-only', nodeSize: 6 },
+			{ pos: 6, type: 'text-only', nodeSize: 6 },
 		])
 	})
 
@@ -60,8 +60,8 @@ describe('extractLinkParagraphs', () => {
 		const doc = prepareDoc(content)
 		const paragraphs = extractLinkParagraphs(doc)
 		expect(paragraphs).toEqual([
-			{ offset: 0, type: 'text-only', nodeSize: 6 },
-			{ offset: 6, type: 'link-preview', nodeSize: 6 },
+			{ pos: 0, type: 'text-only', nodeSize: 6 },
+			{ pos: 6, type: 'link-preview', nodeSize: 6 },
 		])
 	})