-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migration to task processing api #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 8, 2024
marcelklehr
reviewed
Aug 9, 2024
nc.log(LogLvl.ERROR, str(exc)) | ||
if task: | ||
nc.providers.task_processing.report_result(task["id"], error_message=str(exc)) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to extract this!
marcelklehr
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very clean! 🎉
Signed-off-by: Anupam Kumar <[email protected]>
kyteinsky
force-pushed
the
enh/task-processing
branch
from
August 9, 2024 14:15
f9b6053
to
0e504e2
Compare
bigcat88
added a commit
to cloud-py-api/nc_py_api
that referenced
this pull request
Aug 11, 2024
All related PRs: #284 nextcloud/app_api#359 nextcloud/translate2#11 --------- Signed-off-by: Anupam Kumar <[email protected]> Signed-off-by: Alexander Piskun <[email protected]> Co-authored-by: Alexander Piskun <[email protected]>
bigcat88
added a commit
to nextcloud/app_api
that referenced
this pull request
Aug 12, 2024
All related PRs: cloud-py-api/nc_py_api#284 #359 nextcloud/translate2#11 Signed-off-by: Anupam Kumar <[email protected]> Co-authored-by: Alexander Piskun <[email protected]>
bigcat88
approved these changes
Aug 12, 2024
marcelklehr
reviewed
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All related PRs:
cloud-py-api/nc_py_api#284
nextcloud/app_api#359
#11