Notification screen & tray icons customizations

[surinder-tsys]

NMC-1902: Notification customizations.
NMC-2250: Notification tray icon customized.

[tobiasKaminsky]

(nc vs mc)

[surinder-tsys]

@tobiasKaminsky
This PR contains the following:

1. Divider added between the list items.
2. Action buttons are customized when someone share's the file. Refer the below screenshot:
   

[tobiasKaminsky]

So change is that secondary button is not filled?

[tobiasKaminsky]

https://m3.material.io/components/buttons/overview

We can use this to update our buttons…
@jancborchardt which do you prefer or shall we keep (2) for primary and (3) for secondary?
Or go with (2) for primary and (4) for secondary?

[jancborchardt]

Cause there can be a lot of primary and secondary buttons here, we should go with (3) tonal for primary and (5) text for secondary. (2) filled should only be used for primary if it is the only primary on the screen.

Also 2 remarks:

• We can take the divider lines upstream too, no need to only put that in a fork?
• The "Accept"/"Reject" buttons don't really make sense for any of the notifications shown in the screenshot of Notification screen & tray icons customizations #66 (comment) – in all of these cases it only needs a call to action button, and the "Reject" button is the dismiss x on the top right.

[tobiasKaminsky]

Cause there can be a lot of primary and secondary buttons

No, this is not possible. We agreed to have only 1 primary (obviously) and at most 1 secondary. If more, then this will be "more" button, leading to a list.

[tobiasKaminsky]

We can take the divider lines upstream too, no need to only put that in a fork?

divider were removed upon your request back then. We do not have them anywhere, not in files, not in activity.

• The "Accept"/"Reject" buttons don't really make sense for any of the notifications shown in the screenshot of

I assume that this is only testing content.

[tobiasKaminsky]

Cause there can be a lot of primary and secondary buttons

No, this is not possible. We agreed to have only 1 primary (obviously) and at most 1 secondary. If more, then this will be "more" button, leading to a list.

Ah, no I probably understand it. You mean multiple primary on screen, not per notification 👍

Then we do it: (3) tonal for primary and (5) text for secondary.

[tobiasKaminsky]

If Jens on MC side is also fine with it, we can push it upstream.
No need to have it here.

[jancborchardt]

divider were removed upon your request back then. We do not have them anywhere, not in files, not in activity.

@tobiasKaminsky yep, and I would still say in the file list that is better as there’s not that much content. However notifications can get longer, so a divider can make sense there.
And above that, let’s just make sure the differences are minimal or nonexistent / mainly consist of theming. :) Makes all our lives easier.

[tobiasKaminsky]

oh boy…Jens wrote me in chat that it is fine to not have divider last week…
now we have two designers with two different opinions.

Please sort this out :) and then we follow :)

[surinder-tsys]

@tobiasKaminsky Jens wrote me the same that no divider is required.
So I have updated the PR without divider.
Let me know if any other changes are required.

[surinder-tsys]

So change is that secondary button is not filled?

@tobiasKaminsky that's right .
We are using secondary button as (4) outlined one and the color we used is not the primary color.

[tobiasKaminsky]

@surinder-tsys

• can you change it to: (3) tonal for primary and (5) text for secondary.
• move to upstream

Jan and Jens are fine with it.

[surinder-tsys]

@surinder-tsys

• can you change it to: (3) tonal for primary and (5) text for secondary.
• move to upstream

Jan and Jens are fine with it.

@tobiasKaminsky I had conversation with Jens and he told that we will keep our style which is:

1. Filled for Primary and Outlined for Secondary.
2. Keeping the blue color for buttons
3. Alignment of them on left side.

Please let me know if still this changes needed to be up-streamed or not required.

[jweidemann]

@jancborchardt Can we please use 2 (filled) as primary? To accept or reject a share is really an action the user should do and normally it wouldnt stack to multople primary buttons in one screen. All the other notification usually don't have buttons there...

As Telekom we also have just 2 and 4 in use - so we would prefer outline button for reject. But if you insist for having 5 (text only button) we can live with that.

[surinder-tsys]

Hi @jancborchardt can you please provide input for Jens previous comment?

[jancborchardt]

Can we please use 2 (filled) as primary?
As Telekom we also have just 2 and 4 in use - so we would prefer outline button for reject. But if you insist for having 5 (text only button) we can live with that.

@jweidemann @surinder-tsys excuse the late reply. Yes, 2 as primary is good with us as well! We never use outlined buttons, so for the reject button I would prefer 5 (text only). Also fine is 3 (lighter filled).

[surinder-tsys]

Can we please use 2 (filled) as primary?
As Telekom we also have just 2 and 4 in use - so we would prefer outline button for reject. But if you insist for having 5 (text only button) we can live with that.

@jweidemann @surinder-tsys excuse the late reply. Yes, 2 as primary is good with us as well! We never use outlined buttons, so for the reject button I would prefer 5 (text only). Also fine is 3 (lighter filled).

@jancborchardt We are also ok with 5 (text only) for reject button. Will be updating the PR.

[surinder-tsys]

@tobiasKaminsky PR has been up-streamed: nextcloud#11693

Upstreamed code will be removed once the PR is merged.