Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nmc/1929 Collabora #70

Closed
wants to merge 1 commit into from
Closed

Nmc/1929 Collabora #70

wants to merge 1 commit into from

Conversation

surinder-tsys
Copy link

@surinder-tsys surinder-tsys commented Apr 20, 2023 •
edited
Loading

Customization for office file icons & text localization.
Mime type added for formula & graphics.
Different icon & text for Markdown (.md) file.

  • Tests written, or not not needed

@surinder-tsys surinder-tsys added the custom MagentaCLOUD customisation label Apr 20, 2023
tobiasKaminsky
tobiasKaminsky reviewed Apr 21, 2023
View reviewed changes
app/src/main/java/com/owncloud/android/ui/fragment/OCFileListBottomSheetDialog.java
creatorViewBinding.creatorThumbnail.getContext(),
viewThemeUtils));
//for NMC we have different text and icon for Markdown(.md) menu
if (creator.getMimetype().equalsIgnoreCase(MimeTypeUtil.MIMETYPE_TEXT_MARKDOWN)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my test this now shows "create text document" with new icon, but when clicking on it, it still suggests to create "empty file.md".
(as this is done by server always a Markdown file will be created)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's right clicking action is same we have just changed new text and icon for it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then please change this directly in strings.xml and simply change xml icon file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be added at run time when the creators have the data. And it is using LinearLayout to add the views.
So if i will add text and icon in xml then i will have to comment the creators logic.

@surinder-tsys surinder-tsys force-pushed the nmc/1929-collabora branch 4 times, most recently from 119656c to 73e9634 Compare June 29, 2023 20:49
@surinder-tsys surinder-tsys added the build-ready Customization to include into build label Jul 13, 2023
@surinder-tsys surinder-tsys force-pushed the nmc/1929-collabora branch 2 times, most recently from 3d6139b to 9dcdd1d Compare January 11, 2024 11:13
@surinder-tsys surinder-tsys changed the title Nmc/1929 collabora Nmc/1929 Collabora Feb 8, 2024
@surinder-tsys surinder-tsys mentioned this pull request Feb 8, 2024
Closed
@github-actions github-actions bot mentioned this pull request Apr 23, 2024
Closed
@github-actions github-actions bot mentioned this pull request Sep 16, 2024
Open
@surinder-tsys
Copy link
Author

This PR code has been moved to #88 to optimize PRs.

@surinder-tsys surinder-tsys deleted the nmc/1929-collabora branch October 28, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky left review comments

Assignees
No one assigned
Labels
approved build-ready Customization to include into build custom MagentaCLOUD customisation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surinder-tsys @tobiasKaminsky