Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nmc/1924 Sharing customizations #75

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Nmc/1924 Sharing customizations #75

wants to merge 2 commits into from

Conversation

surinder-tsys
Copy link

@surinder-tsys surinder-tsys commented May 5, 2023 •
edited
Loading

This PR contains the following:

  1. Different icons for shared, share-received.
  2. Using only Internal, External and Link shares.
  3. Different permissions for Link, Internal and external shares based on the type of file and folders.
  4. Displaying folder/file(preview) icon on FileDetailFragment.
  5. Share suggestion list customization.
  6. Removed comments tab, so no ViewPager is used.
  7. Showing shared labels in landscape mode and tablet device on file listview.

NMC-3599 --> New Sharing UI updated.

  • Tests written, or not not needed

@surinder-tsys surinder-tsys added the custom MagentaCLOUD customisation label May 5, 2023
@surinder-tsys surinder-tsys force-pushed the nmc/1924-sharing branch 2 times, most recently from 67d617f to 688d6b0 Compare May 16, 2023 07:40
@surinder-tsys surinder-tsys force-pushed the nmc/1924-sharing branch 5 times, most recently from 4df1599 to e21f356 Compare May 19, 2023 11:36
@surinder-tsys surinder-tsys force-pushed the nmc/1924-sharing branch 3 times, most recently from 72ed229 to 4fa6146 Compare May 30, 2023 10:48
@surinder-tsys surinder-tsys force-pushed the nmc/1924-sharing branch 4 times, most recently from afa1569 to 3f22acb Compare June 15, 2023 09:26
@surinder-tsys surinder-tsys force-pushed the nmc/1924-sharing branch 3 times, most recently from 4951f39 to d1db895 Compare June 27, 2023 18:20
@surinder-tsys
Copy link
Author

Rebase or remove the download limit code once both upstreamed PR is merged by NC:

  1. Download limit for file link share nextcloud/android#11563
  2. Download limit for file link share nextcloud/android-library#1123

@surinder-tsys surinder-tsys changed the title Nmc/1924 sharing Nmc/1924 Sharing customizations Jul 13, 2023
@surinder-tsys surinder-tsys force-pushed the nmc/1924-sharing branch 3 times, most recently from 5860a8d to d6d4e05 Compare August 5, 2024 06:52
@surinder-tsys surinder-tsys force-pushed the nmc/1924-sharing branch 2 times, most recently from 25d9ecd to 882d176 Compare August 26, 2024 07:25
@surinder-tsys surinder-tsys force-pushed the nmc/1924-sharing branch 3 times, most recently from 4b0bd9f to aef61f8 Compare September 9, 2024 10:11
@surinder-tsys surinder-tsys mentioned this pull request Sep 17, 2024
Open
@surinder-tsys surinder-tsys force-pushed the nmc/1924-sharing branch 3 times, most recently from db31995 to 38f3aa2 Compare November 25, 2024 18:46
@surinder-tsys surinder-tsys force-pushed the nmc/1924-sharing branch 10 times, most recently from dfa8066 to b6c4c75 Compare December 17, 2024 05:16
@surinder-tsys
Customizations done for Sharing with test cases.
59556d9 
Download limit functionality added.
Email selection from contact implemented with Test Cases.
@surinder-tsys
Share new ui updated with divider, index icons, colors, empty state.
511d87c 
Received sharing disabled state handled.
Test cases updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
approved build-ready Customization to include into build custom MagentaCLOUD customisation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@surinder-tsys