Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce NumberField #4475

Draft
wants to merge 82 commits into
base: canary
Choose a base branch
from
Draft

feat: introduce NumberField #4475

wants to merge 82 commits into from

Conversation

wingkwong
Copy link
Member

@wingkwong wingkwong commented Jan 1, 2025 •
edited
Loading

📝 Description

TODO:

  • underline variant style
  • realtime validation
  • test cases
  • docs

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

@wingkwong
feat(number-field): init structure
0764168
@wingkwong
Merge branch 'canary' into feat/eng-363
2101db4
@wingkwong
feat(deps): add @nextui-org/button & @react-types/button
0bfd74d
@wingkwong
feat(theme): export number-field
914783f
@wingkwong
feat(number-field): storybook init structure
18d7139
@wingkwong
feat(number-field): add NumberFieldHorizontalStepper
4dff6f1
@wingkwong
feat(number-field): add NumberFieldHorizontalStepper
d3ba207
@wingkwong
feat(theme): init number field theme
e9b3049
@wingkwong
feat(number-field): number-field draft
a8a7a77
@wingkwong
refactor(number-field): revise stepper icons
9a9cb46
@wingkwong
feat(shared-icons): add ChevronLeftIcon
5b55991
@wingkwong
feat(theme): stepperButton styles
52d3673
@wingkwong
feat(theme): number-field styles
b67320d
@wingkwong
fix(number-field): label layout
37b06be
@wingkwong
Merge branch 'canary' into feat/eng-363
31b971c
@wingkwong
feat(number-field): vertical stepper wrapper
3adda56
@wingkwong
feat(number-field): use-number-field (wip)
734af76
@wingkwong
feat(number-field): add data-direction
7f49f00
@wingkwong
feat(theme): center the text if it is horizontal stepper
f3f8057
@wingkwong
feat(number-field): add HorizontalStepper
0ddddd6
@wingkwong
feat(number-field): add HideStepper
2cc8470
@wingkwong
chore(number-field): revise minValue & defaultValue
79d2cbc
@wingkwong
feat(docs): init number field structure
c82faa6
@wingkwong
fix(theme): outside-left styles
823bc99
@wingkwong
Merge branch 'canary' into feat/eng-363
14e284b
@wingkwong
refactor(theme): remove labelPlacement styles
8d54dab
@wingkwong
refactor(number-field): remove labelContent logic
5998dea
@wingkwong
refactor(number-field): remove labelPlacement args
7d17aef
@wingkwong
Merge branch 'canary' into feat/eng-363
3f5d8f0
@wingkwong
feat(number-field): helper text
0ad45c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrgarciadev jrgarciadev Awaiting requested review from jrgarciadev jrgarciadev will be requested when the pull request is marked ready for review jrgarciadev is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.

[Feature Request] Number Input props [BUG] - Input Component Type 'number' Only Accepts A String Value
1 participant
@wingkwong