Closed way now assumes geom type Area if schema allows it (#2734)

* failing tests identifying defects

refs #2693

* Update README.md

* Cleanup XXX, XXX2, XXX3 etc attributes (#2684)

* Initial changes

refs: #2683

* Test fixes.

refs: #2683

* Test fix

refs: #2683

* Append to dataset now appends (#2698)

* Added flags to dataset opening

refs: #2697

* Debugging added.

refs: #2697

* Added a test

refs: #2697

* Fixed copyright.

refs: #2697

* add an area geometry situation for power tag

refs #2683

* add test and post processor for riverbank

refs #2693

* Fixed AK030

refs: #2693

* wip area translation fixes

* test runway

* comment out last tds->osm step

* Updated the element converter to assign closed areas the polygon attribute

* add F_CODE aliases, make waterway=riverbank only area, log attrs and geomType

* set test with failing F_CODE/WCC combo for river

* add aliases for all FCODES in schema

* remove debug logging

* enable passing tests

* Created unit tests for ElementConverter and found some issues with OsmSchema::allowsFor()

* add more translation tests, disable logging

* don't translate timestamp to source:datetime for translation server

* Schema changes for geometries (#2740)

* Removed geometry from schema that don't describe geometries and updated OsmSchema::allowsFor() code to ignore empty geometries

* Updated schema checker and copyright.

* Add REST endpoint to describe current session user (#2724)

* Add REST endpoint to describe current session user

refs #2590

* add method for retrieving currently authenticated user
* cleanup other user URIs

* Add REST endpoint to describe current session user

refs #2590

* simplify user serialization
* make some URIs Content-Type aware for xml/json serialization
    * /user/<id>
    * /user/name/<name>
* add deprecated annoation to getSaveUser
* adjust use resource testing http status codes

* copyright

* Add REST endpoint to describe current session user

refs #2590

* make OSM_API_DB public
* fix bug that caused intermittent UI test failures
    * update auth proxy http parser to fix error HPE_UNEXPECTED_CONTENT_LENGTH
        * request/request#2761
        * https://github.com/creationix/http-parser-js

* Remove renderdb creation and node-mapnik-server

refs #2700

* update ui-test dom qualifier

* remove inadvertent addition

* advance hoot-ui commit hash

* Add REST endpoint to describe current session user

refs #2590

* advance hoot-ui commit hash
* randomize test user's user_id to prevent possible conflicts with widely used -1

* Submodule hoot-ui a687db8...100a980 (commits not present)

* Update VAGRANT.md

* Add node conversion to GeometryConverter to fix cropping crash (#2738)

* Add string comps and val aggs to info command (#2737)

* add string comparison and value aggregator class descriptions to the info command

* add manual match count to score-matches output (#2739)

* Removed more schema geometries from non-geometric tags

* Update copyright

conf/schema/REF1.json

@@ -1,13 +1,8 @@
 [
     {
         "dataType": "text",
-        "geometries": [
-            "node",
-            "way",
-            "relation"
-        ],
         "influence": 1,
         "name": "REF1",
         "objectType": "tag"
     }
-]
+]

conf/schema/REF2.json

@@ -1,13 +1,8 @@
 [
     {
         "dataType": "text",
-        "geometries": [
-            "node",
-            "way",
-            "relation"
-        ],
         "influence": 1,
         "name": "REF2",
         "objectType": "tag"
     }
-]
+]

conf/schema/address.json

@@ -1,12 +1,6 @@
 [
     {
         "dataType": "text",
-        "geometries": [
-            "node",
-            "area",
-            "way",
-            "relation"
-        ],
         "influence": 2,
         "mismatchScore": 0.25,
         "name": "abstract_address",

conf/schema/colour.json

@@ -1,11 +1,6 @@
 [
     {
         "dataType": "text",
-        "geometries": [
-            "node",
-            "way",
-            "relation"
-        ],
         "name": "colour",
         "objectType": "tag"
     }

conf/schema/contact.json

@@ -1,11 +1,6 @@
 [
     {
         "dataType": "text",
-        "geometries": [
-            "node",
-            "way",
-            "relation"
-        ],
         "name": "contact:phone",
         "objectType": "tag"
     }

conf/schema/destination.json

@@ -1,11 +1,6 @@
 [
     {
         "dataType": "text",
-        "geometries": [
-            "node",
-            "way",
-            "relation"
-        ],
         "name": "destination",
         "objectType": "tag"
     }

conf/schema/ele.json

@@ -1,11 +1,6 @@
 [
     {
         "dataType": "real",
-        "geometries": [
-            "node",
-            "way",
-            "relation"
-        ],
         "name": "ele",
         "objectType": "tag"
     }

conf/schema/email.json

@@ -1,11 +1,6 @@
 [
     {
         "dataType": "text",
-        "geometries": [
-            "node",
-            "way",
-            "relation"
-        ],
         "name": "email",
         "objectType": "tag"
     }

conf/schema/fire_hydrant.json

@@ -1,10 +1,6 @@
 [
     {
         "dataType": "real",
-        "geometries": [
-            "node",
-            "way"
-        ],
         "name": "fire_hydrant:diameter",
         "objectType": "tag"
     }

conf/schema/frequency.json

@@ -1,11 +1,6 @@
 [
     {
         "dataType": "real",
-        "geometries": [
-            "node",
-            "way",
-            "relation"
-        ],
         "name": "frequency",
         "objectType": "tag"
     }

conf/schema/gauge.json

@@ -1,11 +1,6 @@
 [
     {
         "dataType": "real",
-        "geometries": [
-            "node",
-            "way",
-            "relation"
-        ],
         "name": "gauge",
         "objectType": "tag"
     }

conf/schema/height.json

@@ -1,11 +1,6 @@
 [
     {
         "dataType": "real",
-        "geometries": [
-            "node",
-            "way",
-            "relation"
-        ],
         "name": "height",
         "objectType": "tag"
     }

conf/schema/hoot_tags.json

@@ -1,11 +1,6 @@
 [
     {
         "dataType": "text",
-        "geometries": [
-            "node",
-            "way",
-            "relation"
-        ],
         "influence": 1,
         "isA": "metadata",
         "name": "hoot:hash",

conf/schema/is_in.json

@@ -1,11 +1,6 @@
 [
     {
         "dataType": "text",
-        "geometries": [
-            "node",
-            "way",
-	    "relation"
-        ],
         "name": "abstract_is_in",
         "influence": 1,
         "objectType": "tag"

conf/schema/lanes.json

@@ -1,11 +1,6 @@
 [
     {
         "dataType": "int",
-        "geometries": [
-            "node",
-            "way",
-            "relation"
-        ],
         "name": "lanes",
         "objectType": "tag"
     }

conf/schema/maxspeed.json

@@ -1,11 +1,6 @@
 [
     {
         "dataType": "real",
-        "geometries": [
-            "node",
-            "way",
-            "relation"
-        ],
         "name": "maxspeed",
         "objectType": "tag"
     }

conf/schema/metadata.json

@@ -1,11 +1,6 @@
 [
     {
         "dataType": "text",
-        "geometries": [
-            "node",
-            "way",
-            "relation"
-        ],
         "influence": 0,
         "name": "metadata",
         "objectType": "tag"

conf/schema/name.json

@@ -4,11 +4,6 @@
             "name"
         ],
         "dataType": "text",
-        "geometries": [
-            "node",
-            "way",
-            "relation"
-        ],
         "influence": 2,
         "name": "abstract_name",
         "objectType": "tag"
@@ -58,11 +53,6 @@
             "pseudoname"
         ],
         "dataType": "text",
-        "geometries": [
-            "node",
-            "way",
-            "relation"
-        ],
         "influence": 1,
         "name": "pseudo_name",
         "objectType": "tag"

conf/schema/note.json

@@ -1,11 +1,6 @@
 [
     {
         "dataType": "text",
-        "geometries": [
-            "node",
-            "way",
-            "relation"
-        ],
         "influence": 0,
         "name": "note",
         "objectType": "tag"

conf/schema/opening_hours.json

@@ -1,10 +1,6 @@
 [
     {
         "dataType": "text",
-        "geometries": [
-            "node",
-            "way"
-        ],
         "name": "opening_hours",
         "objectType": "tag"
     }

conf/schema/source.json

@@ -6,11 +6,6 @@
     },
     {
         "dataType": "text",
-        "geometries": [
-            "node",
-            "way",
-            "relation"
-        ],
         "influence": 1,
         "isA": "metadata",
         "name": "source",

conf/schema/url.json

@@ -1,11 +1,6 @@
 [
     {
         "dataType": "text",
-        "geometries": [
-            "node",
-            "way",
-            "relation"
-        ],
         "name": "url",
         "objectType": "tag"
     }

conf/schema/waterway.json

@@ -68,6 +68,9 @@
         "objectType": "tag"
     },
     {
+        "geometries": [
+            "area"
+        ],
         "isA": "waterway",
         "name": "waterway=riverbank",
         "objectType": "tag"

conf/schema/website.json

@@ -1,11 +1,6 @@
 [
     {
         "dataType": "text",
-        "geometries": [
-            "node",
-            "way",
-            "relation"
-        ],
         "name": "website",
         "objectType": "tag"
     }

conf/schema/width.json

@@ -1,11 +1,6 @@
 [
     {
         "dataType": "real",
-        "geometries": [
-            "node",
-            "way",
-            "relation"
-        ],
         "name": "width",
         "objectType": "tag"
     }

conf/schema/wikipedia.json

@@ -1,11 +1,6 @@
 [
     {
         "dataType": "text",
-        "geometries": [
-            "node",
-            "way",
-            "relation"
-        ],
         "name": "wikipedia",
         "objectType": "tag"
     }