Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build instruction link, remove EoS versions from specifications #7137

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

ADubhlaoich
Copy link
Contributor

@ADubhlaoich ADubhlaoich commented Jan 15, 2025

Proposed changes

This commit updates the README in the build subfolder to point to the latest version of the build documentation, as the link was updated as part of previous documentation changes.

It also removes the last two entries from the supported Kubernetes versions table of the Technical specifications page, as they are now out of software and technical support.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

This commit updates the README in the build subfolder to point to the
latest version of the build documentation, as the link was updated as
part of previous documentation changes.

It also removes the last two entries from the supported Kubernetes
versions table of the Technical specifications page, as they are now out
of software and technical support.
@ADubhlaoich ADubhlaoich requested review from a team as code owners January 15, 2025 17:11
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jan 15, 2025
@ADubhlaoich ADubhlaoich added the needs cherry pick Cherry pick this PR into a release branch label Jan 15, 2025
@ADubhlaoich ADubhlaoich self-assigned this Jan 15, 2025
@ADubhlaoich ADubhlaoich marked this pull request as draft January 15, 2025 17:25
@ADubhlaoich
Copy link
Contributor Author

Switching this PR to a draft while I await confirmation about the versions supported.

Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7137/

@ADubhlaoich ADubhlaoich marked this pull request as ready for review January 16, 2025 10:52
@ADubhlaoich ADubhlaoich enabled auto-merge (squash) January 16, 2025 15:44
@ADubhlaoich ADubhlaoich merged commit d0a252f into main Jan 16, 2025
32 checks passed
@ADubhlaoich ADubhlaoich deleted the docs/minor-fixes branch January 16, 2025 15:48
nginx-bot pushed a commit that referenced this pull request Jan 16, 2025
#7137)

This commit updates the README in the build subfolder to point to the
latest version of the build documentation, as the link was updated as
part of previous documentation changes.

It also removes the last two entries from the supported Kubernetes
versions table of the Technical specifications page, as they are now out
of software and technical support.
ADubhlaoich pushed a commit that referenced this pull request Jan 16, 2025
… specifications (#7146)

Update build instruction link, remove EoS versions from specifications (#7137)

This commit updates the README in the build subfolder to point to the
latest version of the build documentation, as the link was updated as
part of previous documentation changes.

It also removes the last two entries from the supported Kubernetes
versions table of the Technical specifications page, as they are now out
of software and technical support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

4 participants