Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add autocomplete example #67

Merged
merged 1 commit into from
Oct 26, 2023
Merged

add autocomplete example #67

merged 1 commit into from
Oct 26, 2023

Conversation

ryepup
Copy link
Collaborator

@ryepup ryepup commented Oct 23, 2023

Proposed changes

demos creating updated datasets compatible with https://github.com/jaywcjlove/nginx-editor.

Had to set the reference-lib package as a "module" to avoid import errors like:

Named export 'Format' not found. The requested module '@nginxinc/reference-lib' is a CommonJS module, which may not support all module.exports as named exports

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

demos creating updated datasets compatible with https://github.com/jaywcjlove/nginx-editor.

Had to set the reference-lib package as a "module" to avoid `import` errors like:

> Named export 'Format' not found. The requested module '@nginxinc/reference-lib' is a CommonJS module, which may not support all module.exports as named exports
@ryepup ryepup merged commit b5d4b3f into main Oct 26, 2023
1 check passed
@ryepup ryepup deleted the autocomplete branch October 26, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants