Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #115

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

bavshin-f5
Copy link
Member

db065fa does not build with 1.79.0, but reordering the commits only makes things worse because bindgen::RustTarget::from_str in 0.70.x is unable to parse the full Rust version string.

In case if you are wondering why we are not using dependabot, here's the update task status:

https://github.com/nginxinc/ngx-rust/network/updates/943285251

Update check skipped
Dependabot updates have stopped for your repository due to repeated errors. To see logs, click "Check for Updates" and Dependabot will try again. The last error message was:
Dependabot can't resolve your Rust dependency files

Dependabot failed to update your dependencies because there was an error resolving your Rust dependency files.

Dependabot encountered the following error:

error: failed to load manifest for workspace member `dependabot_tmp_dir/examples`
referenced by workspace at `dependabot_tmp_dir/Cargo.toml`

Caused by:
  failed to parse manifest at `dependabot_tmp_dir/examples/Cargo.toml`

Caused by:
  the binary target name `examples` is forbidden, it conflicts with cargo's build directory names

I am aware of problem now and will eventually fix.

Update `deny.toml` to reflect the `unicode-ident` license change.

Pin `idna_adapter` to `~1.0` as suggested in the documentation, to avoid
pulling the `icu_normalizer` dependency.  There are 4 domains we access
from the build script and all of these are ASCII.
It appears that bindgen generates the code for the latest known stable
by default, and the output has changed in 0.71 when targeting 1.82+ due
to introduction of `unsafe extern` blocks.
Restore the compilation with MSRV by passing explicit RustTarget to
bindgen.
Copy link

@xeioex xeioex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bavshin-f5 bavshin-f5 merged commit a575249 into nginx:master Jan 7, 2025
10 checks passed
@bavshin-f5 bavshin-f5 deleted the dependahuman branch January 7, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants