feat: 🔥 Replace use of random index logic with getRandomInRange

✅ Closes: #220
ngneat · Mar 22, 2022 · 713c77d · 713c77d
1 parent 6b57aa0
commit 713c77d
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/packages/falso/src/lib/core/core.ts b/packages/falso/src/lib/core/core.ts
@@ -74,7 +74,7 @@ export function fakeFromArray<T, Options extends FakeOptions>(
   const newArray: T[] = [];
 
   while (clonedData.length && newArray.length !== options.length) {
-    const randomIndex = getRandomInRange({ min: clonedData.length });
+    const randomIndex = getRandomInRange({ max: clonedData.length - 1 });
     const item = clonedData[randomIndex];
 
     newArray.push(item);
@@ -85,7 +85,8 @@ export function fakeFromArray<T, Options extends FakeOptions>(
 }
 
 export function randElement<T>(arr: T[]): T {
-  return arr[Math.floor(random() * arr.length)];
+  const randomIndex = getRandomInRange({ max: arr.length - 1 });
+  return arr[randomIndex];
 }
 
 export interface RandomInRangeOptions {