Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(img): allow generating random image by default #385

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

raflymln
Copy link
Contributor

@raflymln raflymln commented Nov 2, 2024

Previously, the resulting image would be cached by the browser. So, when using randImg() on a set of components like React or Solid, the images between components will be the same. I just added the random option as described at https://picsum.photos in the Advanced Usage section.

The option random should be enabled as it would commonly used in this situation.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Copy link

stackblitz bot commented Nov 2, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@NetanelBasal NetanelBasal merged commit e89b27b into ngneat:main Nov 3, 2024
2 checks passed
@raflymln raflymln deleted the patch-1 branch November 10, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants