Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update love.plot to be compatible with upcoming ggplot2 version #80

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Update love.plot to be compatible with upcoming ggplot2 version #80

merged 1 commit into from
Jan 16, 2024

Conversation

teunbrand
Copy link
Contributor

Hello there,

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break cobalt.

In the next version, a plot can have legends at multiple locations. This goes against the expectation in love.plot() that there is one, and only one, legend per plot. This PR updates love.plot() to deal with the new legend structure in ggplot2.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of Februari. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help cobalt get out a fix if necessary.

@ngreifer ngreifer merged commit b082657 into ngreifer:master Jan 16, 2024
1 check passed
@ngreifer
Copy link
Owner

Thank you very much for this!

@teunbrand teunbrand deleted the ggplot2_3.5.0 branch January 16, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants