Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding new ip intel categories #1122

Merged
merged 5 commits into from
Jan 10, 2025
Merged

feat: adding new ip intel categories #1122

merged 5 commits into from
Jan 10, 2025

Conversation

russorat
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ngrok-docs ✅ Ready (Inspect) Visit Preview Jan 10, 2025 6:56pm

@russorat russorat requested a review from DevMandy January 10, 2025 18:05
| `blocklist.org.firehol.abusers_1d` | From [firehol.org](https://iplists.firehol.org/?ipset=firehol_abusers_1d): An ipset made from blocklists that track abusers in the last 24 hours. | [Source](https://iplists.firehol.org/files/firehol_abusers_1d.netset) |
| `blocklist.org.firehol.abusers_30d` | From [firehol.org](https://iplists.firehol.org/?ipset=firehol_abusers_30d): An ipset made from blocklists that track abusers in the last 30 days. | [Source](https://iplists.firehol.org/files/firehol_abusers_30d.netset) |
| `blocklist.org.firehol.level_1` | From [firehol.org](https://iplists.firehol.org/?ipset=firehol_level1): The objective is to create a blacklist that can be safe enough to be used on all systems, with a firewall, to block access entirely, from and to its listed IPs. The key prerequisite for this cause, is to have no false positives. All IPs listed should be bad and should be blocked, without exceptions. | [Source](https://iplists.firehol.org/files/firehol_level1.netset) |
| `blocklist.org.firehol.level_2` | From [firehol.org](https://iplists.firehol.org/?ipset=firehol_level2): An ipset made from blocklists that track attacks, during the last 48 hours. | [Source](https://iplists.firehol.org/files/firehol_level2.netset) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see these descriptions removed from this table, but I've created a separate linear issue for that instead of slowing this PR down:
https://linear.app/ngrok/issue/DOC-12/remove-unnecessary-descriptions-from-the-ip-intel-var-docs

Copy link
Collaborator

@S3Prototype S3Prototype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one suggested change

traffic-policy/variables/conn.ip-intel.categories.mdx Outdated Show resolved Hide resolved
I'm just gonna commit this and get it merged so you can move on
@S3Prototype S3Prototype dismissed DevMandy’s stale review January 10, 2025 18:53

All issues have been addressed; dismissing so we can merge

@russorat russorat merged commit 4d679b7 into main Jan 10, 2025
3 checks passed
@russorat russorat deleted the ror/ip-intel-2025-01-09 branch January 10, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants