lowercase feature names are supported now

ngrok · Dec 12, 2024 · 0cccc01 · 0cccc01
1 parent a86e1d6
commit 0cccc01
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/internal/controller/ngrok/kubernetesoperator_controller.go b/internal/controller/ngrok/kubernetesoperator_controller.go
@@ -55,11 +55,10 @@ import (
 	"github.com/ngrok/ngrok-operator/internal/ngrokapi"
 )
 
-// TODO: features need to be capitalized in the ngrok API currently, this is subject to change
 var featureMap = map[string]string{
-	ngrokv1alpha1.KubernetesOperatorFeatureBindings: "Bindings",
-	ngrokv1alpha1.KubernetesOperatorFeatureIngress:  "Ingress",
-	ngrokv1alpha1.KubernetesOperatorFeatureGateway:  "Gateway",
+	ngrokv1alpha1.KubernetesOperatorFeatureBindings: "bindings",
+	ngrokv1alpha1.KubernetesOperatorFeatureIngress:  "ingress",
+	ngrokv1alpha1.KubernetesOperatorFeatureGateway:  "gateway",
 }
 
 // KubernetesOperatorReconciler reconciles a KubernetesOperator object

diff --git a/internal/controller/ngrok/kubernetsoperator_controller_test.go b/internal/controller/ngrok/kubernetsoperator_controller_test.go
@@ -31,7 +31,7 @@ func TestCalculateFeaturesEnabled(t *testing.T) {
 					},
 				},
 			},
-			expected: []string{"Bindings", "Ingress", "Gateway"},
+			expected: []string{"bindings", "ingress", "gateway"},
 		},
 	}
-Original file line number
+Diff line change
@@ Expand Up / @@ -31,7 +31,7 @@ func TestCalculateFeaturesEnabled(t *testing.T) { @@
     					},
     				},
     			},
-    			expected: []string{"Bindings", "Ingress", "Gateway"},
+    			expected: []string{"bindings", "ingress", "gateway"},
     		},
     	}
@@ Expand Down @@