refactor: Split the agent and api controllers #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
natasha-jarus
approved these changes
Oct 11, 2024
alex-bezek
reviewed
Oct 11, 2024
alex-bezek
reviewed
Oct 11, 2024
alex-bezek
approved these changes
Oct 11, 2024
hjkatz
approved these changes
Oct 14, 2024
|
|
||
| ### Overview | ||
|
|
||
| Previously, in the ngrok Ingress Controller, the Tunnel Controller(non leader-elected) ran under the same manager as the rest of the API controllers(leader-elected). This did not allow users to independetly scale the data forwarding and API management features. Going forward, we will be splitting the Tunnel Controller into its own manager so that it can be scaled independently of the rest of the controllers. This will allow users to scale the data forwarding and API management features independently. |
There was a problem hiding this comment.
Nit: I like the historical context, but I feel that the history should come after the present.
Perhaps this paragraph can be 2 paragraphs:
- The current architectural intent with 2 deployments
- The historical reasoning
There was a problem hiding this comment.
I like that format. This will change again once we include the bindings forwarder. I think I'm going to leave it for now since it will get changed soon and reword it for current state once we have the bindings piece
Splits the agent and API controllers into their own managers and k8s deployments. This separates the data path from the API configuration path so that one or the other can easily be turned on or off and scaled independently.
jonstacks
force-pushed
the
agent-api-split
branch
from
b19cf1f to
87c5c0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Splits the agent and API controllers into their own managers and k8s deployments. This separates the data path from the API configuration path so that one or the other can easily be turned on or off and scaled independently. This also helps with providing an upgrade path from the ngrok Ingress Controller to the new ngrok operator.
How
Breaking Changes
There should not be. This should be a passive change.