Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm): Add support for nodeSelectors, tolerations, and topologyS… #559

Merged
merged 1 commit into from
Dec 19, 2024
Merged

feat(helm): Add support for nodeSelectors, tolerations, and topologyS… #559

merged 1 commit into from
Dec 19, 2024

Conversation

jonstacks
Copy link
Collaborator

Fixes #557

What

Add support for nodeSelectors, tolerations, and topologySpreadConstraints.

How

  • Add these to the values.yaml and allow them to be configured for the bindings-forwarder, agent, and api manager. The top level values are for the api manager. We have plans to nest this in the future so that there can be global config that applies to all of these deployments, but for now, stick with this pattern.
  • Also, move up the podAnnotations and podLabels config to the common section, since they are common configuration and not specific to the API/main manager.

Breaking Changes

No

@jonstacks jonstacks added the enhancement New feature or request label Dec 18, 2024
@jonstacks jonstacks self-assigned this Dec 18, 2024
@jonstacks jonstacks requested a review from a team as a code owner December 18, 2024 21:03
@github-actions github-actions bot added the area/helm-chart Issues dealing with the helm chart label Dec 18, 2024
@jonstacks jonstacks added this pull request to the merge queue Dec 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 19, 2024
@jonstacks jonstacks added this pull request to the merge queue Dec 19, 2024
Merged via the queue into ngrok:main with commit 5e5c0b8 Dec 19, 2024
9 checks passed
@jonstacks jonstacks deleted the issue-557 branch December 19, 2024 23:28
@Johndot1
Copy link

Ey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Johndot1 Johndot1 Johndot1 approved these changes

@Alice-Lilith Alice-Lilith Alice-Lilith approved these changes

Assignees

@jonstacks jonstacks

Labels
area/helm-chart Issues dealing with the helm chart enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Helm] Support for nodeSelectors, podTopologyConstraints, and tolerations
3 participants
@jonstacks @Johndot1 @Alice-Lilith