Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Disable bindings for e2e tests #570

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

jonstacks
Copy link
Collaborator

Noticed CI is failing on #569. Possibly related to #567 and the underlying change in the API.

What

Bindings is undergoing some changes in the API. Disable bindings in e2e for now since I think that is the source of the issue.

How

  • Hoping that disabling bindings will make our e2e tests work

Breaking Changes

No

@jonstacks jonstacks self-assigned this Jan 13, 2025
@jonstacks jonstacks requested a review from a team as a code owner January 13, 2025 15:22
@jonstacks jonstacks added this pull request to the merge queue Jan 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2025
@jonstacks jonstacks added this pull request to the merge queue Jan 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2025
@jonstacks jonstacks force-pushed the disable-bindings-e2e branch from 6a02478 to f3084bb Compare January 13, 2025 18:46
@jonstacks jonstacks enabled auto-merge January 13, 2025 18:47
@jonstacks jonstacks added this pull request to the merge queue Jan 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2025
@jonstacks jonstacks force-pushed the disable-bindings-e2e branch from f3084bb to 0e749ca Compare January 13, 2025 19:10
@jonstacks jonstacks enabled auto-merge January 13, 2025 19:10
@jonstacks jonstacks added this pull request to the merge queue Jan 13, 2025
Merged via the queue into ngrok:main with commit 9a10ccd Jan 13, 2025
8 checks passed
@jonstacks jonstacks deleted the disable-bindings-e2e branch January 13, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants