Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change allowed_urls to endpoint_selectors #573

Merged
merged 11 commits into from
Jan 15, 2025
Merged

Conversation

masonj5n
Copy link
Member

@masonj5n masonj5n commented Jan 15, 2025

What

The ngrok api is changing allowed_urls to endpoint_selectors, this change reflects that api change and removes the operator-side filtering of allowed_urls as the filtering with endpoint_selectors will happen server-side.

How

Modify values.yaml -> template -> service flags

Breaking Changes

Yes, the KubernetesOperatorBinding and BoundEndpointSpec resources are changing, which may affect people who already have instances of those resources deployed.

@github-actions github-actions bot added area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart labels Jan 15, 2025
Base automatically changed from mason/remove_binding_name to main January 15, 2025 17:20
@masonj5n masonj5n force-pushed the mason/use-endpoint-selectors branch 2 times, most recently from a033830 to 10559c3 Compare January 15, 2025 17:35
@masonj5n masonj5n force-pushed the mason/use-endpoint-selectors branch from 53e1919 to 0cbb9a5 Compare January 15, 2025 17:38
@masonj5n masonj5n marked this pull request as ready for review January 15, 2025 17:45
@masonj5n masonj5n requested a review from a team as a code owner January 15, 2025 17:45
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 23.66%. Comparing base (91d1ccb) to head (0cbb9a5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/api/main.go 0.00% 4 Missing ⚠️
api/ngrok/v1alpha1/zz_generated.deepcopy.go 0.00% 2 Missing ⚠️
.../controller/ngrok/kubernetesoperator_controller.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #573      +/-   ##
==========================================
- Coverage   24.11%   23.66%   -0.45%     
==========================================
  Files          88       88              
  Lines       12571    12444     -127     
==========================================
- Hits         3031     2945      -86     
+ Misses       9350     9312      -38     
+ Partials      190      187       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@masonj5n masonj5n added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 3ef67b6 Jan 15, 2025
9 of 11 checks passed
@masonj5n masonj5n deleted the mason/use-endpoint-selectors branch January 15, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants