-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change allowed_urls to endpoint_selectors #573
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/controller
Issues dealing with the controller
area/helm-chart
Issues dealing with the helm chart
labels
Jan 15, 2025
jonstacks
approved these changes
Jan 15, 2025
masonj5n
force-pushed
the
mason/use-endpoint-selectors
branch
2 times, most recently
from
January 15, 2025 17:35
a033830
to
10559c3
Compare
masonj5n
force-pushed
the
mason/use-endpoint-selectors
branch
from
January 15, 2025 17:38
53e1919
to
0cbb9a5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #573 +/- ##
==========================================
- Coverage 24.11% 23.66% -0.45%
==========================================
Files 88 88
Lines 12571 12444 -127
==========================================
- Hits 3031 2945 -86
+ Misses 9350 9312 -38
+ Partials 190 187 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/controller
Issues dealing with the controller
area/helm-chart
Issues dealing with the helm chart
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The ngrok api is changing
allowed_urls
toendpoint_selectors
, this change reflects that api change and removes the operator-side filtering ofallowed_urls
as the filtering withendpoint_selectors
will happen server-side.How
Modify values.yaml -> template -> service flags
Breaking Changes
Yes, the KubernetesOperatorBinding and BoundEndpointSpec resources are changing, which may affect people who already have instances of those resources deployed.