Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add newly created agent endpoints to the map #574

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

Alice-Lilith
Copy link
Contributor

We can't delete agent endpoints when the AgentEndpoint custom resources are deleted because we never add them to the map that tracks them. Adding the entry to the map makes this work as intended.

@Alice-Lilith Alice-Lilith requested a review from a team as a code owner January 16, 2025 00:47
@github-actions github-actions bot added the area/controller Issues dealing with the controller label Jan 16, 2025
@Alice-Lilith Alice-Lilith force-pushed the alicewasko/delete-deleted-agent-endpoints branch from e226689 to 5cb9281 Compare January 16, 2025 01:01
Copy link
Collaborator

@jonstacks jonstacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alice-Lilith Alice-Lilith added this pull request to the merge queue Jan 16, 2025
@jonstacks jonstacks added the bug Something isn't working label Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 23.66%. Comparing base (3ef67b6) to head (5cb9281).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/tunneldriver/driver.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
- Coverage   23.66%   23.66%   -0.01%     
==========================================
  Files          88       88              
  Lines       12444    12446       +2     
==========================================
  Hits         2945     2945              
- Misses       9312     9314       +2     
  Partials      187      187              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit 0fac123 Jan 16, 2025
9 of 10 checks passed
@Alice-Lilith Alice-Lilith deleted the alicewasko/delete-deleted-agent-endpoints branch January 16, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Issues dealing with the controller bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants