Fix: Limit when to prevent the default wheel event (fix #1848) #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpetrioli
changed the title
|
Just a heads up, it looks like PR #1816 introduced a very greedy event handler, that completely consumes all This fix introduces some checks that will allow an event to bubble to the top (not get consumed by the handler) if the grid does not need to consume it (if there is no scroll to happen in the direction the wheel events is occurring). |
gpetrioli
changed the title
Only prevent the default event when there will be internal grid scroll
gpetrioli
force-pushed
the
bugfix/limit-wheel-prevent
branch
from
c5331ed to
3f4597d
Compare
|
This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
The code prevents the default wheel event only if there is available scroll inside the grid that will happen.
This means that when we have reached the end of the scroll in all directions, it will allow the wheel event to bubble higher and be caught by the browser so that the page will continue scrolling.
Fixes #1848