Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #54

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

svelderrainruiz
Copy link
Collaborator

Adding more details

Adding more details
@svelderrainruiz svelderrainruiz self-assigned this Oct 27, 2024
CONTRIBUTING.md Outdated
* The latest version of the LabVIEW Icon Editor (not published yet) can be found {latest_version_link}

# Our Contributing Philosophy
Just recently, the LabVIEW Icon Editor has been made open source to encourage collaboration between NI and the LabVIEW Community. Every new build of LabVIEW will grab the icon editor that has been pushed into the main branch from this repo.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use backticks when referencing the main branch to avoid any ambiguity that "main" is the name of the branch and not just the default branch. @svelderrainruiz

CONTRIBUTING.md Outdated
# How can I help?

The things we need the most help for the library and its community are:

**🐛 Bug reports:** We simply can’t catch them all. Check [existing issues](https://github.com/ni/labview-icon-editor/issues/new/choose) and discussion first, then [create a new issue](https://github.com/ni/labview-icon-editor/issues/new/choose) to tell us what’s up.

**💬 Answering questions** in our {discussion_form} or {community_discord}.
**💬 Answering questions and provide feedback**: New features begin by creating a discussion on our board, you can provide feedback to the new features that are planned to be added to the icon editor.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make "our discussion board" a link to the actual discussion board. @svelderrainruiz

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[discussion form](https://github.com/ni/labview-icon-editor/discussions)

CONTRIBUTING.md Outdated

🎬 **Create tutorials**. Send them to us and we’ll happily share them!
🎬 **Work on "Good first issue" items**: You can right now assign yourself action items to finish or test a feature. Check out the issues section and look for any issue labeled as "Good first problem" if you want to passively contribute to the repo, or if you are feeling adventurous you can always assign problems not labeled as "Good first issue".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make "good first issues" text a link to the issues list, filtered to only show "good for issues" @svelderrainruiz

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this Good First Issues
[Good First Issues](https://github.com/ni/labview-icon-editor/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22)

2. {step_2}
3. Test your changes by editing the icons of some VIs
4. Run tests `caraya` and add new tests if you are introducing a new feature
When submitting a PR, please follow these guidelines to ensure clarity and ease
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svelderrainruiz It's possible to set up a template where a user can fill in the blanks almost like a form. @svelderrainruiz

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certificate of Origin (see below) and are able to legally submit your code to
this repository.

### Reporting Issues
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svelderrainruiz I'm not at my computer, but if you remind me, I can point you to how to set up templates for issues/pull-requests

Copy link
Collaborator

@jimkring jimkring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

added links and removed additional text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants