-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created Wafer Map worker colors and text renderer #2154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munteannatan
changed the base branch from
main
to
users/munteannatan/refactor-update-cycle
June 3, 2024 20:34
atmgrifter00
reviewed
Jun 3, 2024
packages/nimble-components/build/generate-workers/source/matrix-renderer.ts
Outdated
Show resolved
Hide resolved
atmgrifter00
reviewed
Jun 3, 2024
packages/nimble-components/build/generate-workers/source/matrix-renderer.ts
Outdated
Show resolved
Hide resolved
atmgrifter00
reviewed
Jun 3, 2024
packages/nimble-components/build/generate-workers/source/matrix-renderer.ts
Show resolved
Hide resolved
atmgrifter00
reviewed
Jun 3, 2024
packages/nimble-components/build/generate-workers/source/matrix-renderer.ts
Outdated
Show resolved
Hide resolved
atmgrifter00
approved these changes
Jun 3, 2024
munteannatan
requested review from
rajsite,
jattasNI and
DStavilaNI
as code owners
June 4, 2024 17:46
rajsite
reviewed
Jun 4, 2024
jattasNI
reviewed
Jun 4, 2024
rajsite
reviewed
Jun 4, 2024
packages/nimble-components/src/wafer-map/tests/wafer-map.spec.ts
Outdated
Show resolved
Hide resolved
11 tasks
rajsite
reviewed
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good, just have concerns about test pattern and making sure the tests run reliably.
jattasNI
approved these changes
Jun 7, 2024
rajsite
reviewed
Jun 7, 2024
packages/nimble-components/build/generate-workers/source/matrix-renderer.ts
Show resolved
Hide resolved
rajsite
approved these changes
Jun 7, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π€¨ Rationale
We needed to display the colors from the color scale and the values as text on the offscreen wafer image.
π©βπ» Implementation
Created a color map and stored indexes in place of values.
created separate draw text method and called it based on user settings and die size
π§ͺ Testing
Created new renderer test for hidden labels
Duplicated existing matrix UI tests
Small bug with grid dimensions, will investigate it
β Checklist