Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Wafer Map worker colors and text renderer #2154

Merged
merged 35 commits into from
Jun 7, 2024

Conversation

munteannatan
Copy link
Contributor

@munteannatan munteannatan commented Jun 3, 2024

Pull Request

🀨 Rationale

We needed to display the colors from the color scale and the values as text on the offscreen wafer image.

πŸ‘©β€πŸ’» Implementation

Created a color map and stored indexes in place of values.
created separate draw text method and called it based on user settings and die size

πŸ§ͺ Testing

Created new renderer test for hidden labels
Duplicated existing matrix UI tests
Small bug with grid dimensions, will investigate it

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@munteannatan munteannatan changed the base branch from main to users/munteannatan/refactor-update-cycle June 3, 2024 20:34
@munteannatan munteannatan requested a review from atmgrifter00 June 3, 2024 20:35
Base automatically changed from users/munteannatan/refactor-update-cycle to main June 3, 2024 20:50
@munteannatan munteannatan marked this pull request as ready for review June 4, 2024 17:46
@munteannatan munteannatan requested review from rajsite and jattasNI June 5, 2024 21:52
Copy link
Member

@rajsite rajsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good, just have concerns about test pattern and making sure the tests run reliably.

@munteannatan munteannatan requested a review from rajsite June 6, 2024 18:39
@rajsite rajsite merged commit d5ad24b into main Jun 7, 2024
13 checks passed
@rajsite rajsite deleted the users/munteannatan/clors-and-text branch June 7, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants