node8, const, async #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramesius
suggested changes
Jun 25, 2018
src/index.js
Outdated
| @@ -78,21 +63,21 @@ function deleteStacks(stacks, dryRun) { | |||
| }); | |||
| } | |||
|
|
|||
| function listAllStacksWrapper() { | |||
| const listAllStacksWrapper = async () => { | |||
There was a problem hiding this comment.
If we are not awaiting anything in this block then we can ditch the Async keyword
There was a problem hiding this comment.
that was awaited in line 14, but i've removed the intermediate listAllStacksWrapper that isn't needed now
There was a problem hiding this comment.
Unless you are awaiting within the code block you don't need the async keyword. You can still use await on line 14 since promises are awaitable
There was a problem hiding this comment.
It is now awaiting on the cloudformation api call in https://github.com/nib-health-funds/cfn-batman/pull/17/files#diff-1fdf421c05c1140f6d71444ea2b27638R69
src/index.js
Outdated
| return new Promise((resolve, reject) => { | ||
| return listAllStacks(null, [], resolve, reject); | ||
| }); | ||
| } | ||
|
|
||
| function listAllStacks(token, stackArray, resolve, reject) { | ||
| const listAllStacks = async (token, stackArray, resolve, reject) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.