Skip to content

Commit

Permalink
pkp/pkp-lib#9456 Refactor for private notes
Browse files Browse the repository at this point in the history
  • Loading branch information
nibou230 committed Nov 24, 2023
1 parent 023b1c3 commit 8cdb82d
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
8 changes: 4 additions & 4 deletions src/components/ListPanel/users/SelectReviewerListItem.vue
Original file line number Diff line number Diff line change
Expand Up @@ -193,11 +193,11 @@
</div>
<div v-html="item.gossip"></div>
</list-item>
<list-item v-if="item.privateNotes">
<list-item v-if="item.userPrivateNote">
<div class="listPanel__item--reviewer__detailHeading">
{{ privateNotesLabel }}
{{ userPrivateNotesLabel }}
</div>
<div v-html="item.privateNotes"></div>
<div v-html="item.userPrivateNote"></div>
</list-item>
<list-item v-if="localize(item.biography)">
<div class="listPanel__item--reviewer__detailHeading">
Expand Down Expand Up @@ -288,7 +288,7 @@ export default {
type: String,
required: true,
},
privateNotesLabel: {
userPrivateNotesLabel: {
type: String,
required: true,
},
Expand Down
4 changes: 2 additions & 2 deletions src/components/ListPanel/users/SelectReviewerListPanel.vue
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
"
:declinedReviewsLabel="declinedReviewsLabel"
:gossipLabel="gossipLabel"
:privateNotesLabel="privateNotesLabel"
:userPrivateNotesLabel="userPrivateNotesLabel"
:key="item.id"
:item="item"
:neverAssignedLabel="neverAssignedLabel"
Expand Down Expand Up @@ -203,7 +203,7 @@ export default {
type: String,
required: true,
},
privateNotesLabel: {
userPrivateNotesLabel: {
type: String,
required: true,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
emptyLabel="No reviewers found"
:filters="filters"
gossipLabel="Editorial Public Notes"
privateNotesLabel="Editorial Private Notes"
userPrivateNotesLabel="Editorial Private Notes"
id="previewSelectReviewerListPanel"
:items="items"
:itemsMax="items.length"
Expand Down Expand Up @@ -73,7 +73,7 @@ export default {
},
gossip:
"<p>Aisla is a terrific reviewer but she takes a while to confirm and complete a review. Recommend not using her if you're on a tight deadline.</p>",
privateNotes:
userPrivateNote:
"<p>Keep this note private. Aisla is a terrific reviewer but she takes a while to confirm and complete a review. Recommend not using her if you're on a tight deadline.</p>",
},
{
Expand Down
2 changes: 1 addition & 1 deletion src/docs/components/ListPanel/readme-select-reviewer.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
| `emptyLabel` | A localized string to display when there are no reviewers to show in the list. |
| `filters` | An array [Filter](#/component/Filter)s. Default: `[]` |
| `gossipLabel` | A localized string for the gossip section. |
| `privateNotesLabel` | A localized string for the private notes section. |
| `userPrivateNotesLabel` | A localized string for the private notes section. |
| `id` | A unique id for this component. |
| `items` | An array of reviewers. Default: `[]` |
| `itemsMax` | A count of all reviewers in the journal, press or preprint server. Default: `0` |
Expand Down

0 comments on commit 8cdb82d

Please sign in to comment.