Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update t6 to v1.1.7 #129

Merged
merged 5 commits into from
Dec 6, 2024
Merged

Update t6 to v1.1.7 #129

merged 5 commits into from
Dec 6, 2024

Conversation

nicfv
Copy link
Owner

@nicfv nicfv commented Dec 6, 2024

I opened this question that would make things easier for me if there was a solution:

https://stackoverflow.com/questions/79256829/how-to-use-version-range-syntax-for-locally-installed-packages

I'm not counting on it, though. This is the next best thing since it will fail immediately.

@nicfv nicfv added the bug Something isn't working label Dec 6, 2024
@@ -1,3 +1,3 @@
#!/usr/bin/env bash

rm -rf dist types && tsc && node dist/test.js && rm dist/test.js types/test.d.ts && npm pack --pack-destination examples
rm -rf dist types && tsc && node dist/test.js && rm dist/test.js types/test.d.ts && npm pack --pack-destination examples && cd examples && npm i
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually uncovered another issue... when I pack things that are dependent on versions that are currently being developed (e.g. not on npm registry) the examples can't find those sub dependencies.

@nicfv
Copy link
Owner Author

nicfv commented Dec 6, 2024

I'm almost feeling like idea #3 is the way forward #123 (comment) here...

If I do a major update on t6 for example, I would need to do a 2nd PR for smath (to update the t6 dependency) and then a 3rd PR to update the other packages (to update both the smath and t6 dependencies...) It's not ideal but everything else is leading me to a dead end.

@nicfv nicfv changed the title Fix the issue where the example versions were outdated Update t6 to v1.1.7 Dec 6, 2024
@nicfv nicfv added npm/t6 About the t6 package and removed bug Something isn't working labels Dec 6, 2024
@nicfv nicfv merged commit 72200de into main Dec 6, 2024
1 check passed
@nicfv nicfv deleted the update branch December 6, 2024 05:05
@@ -1,7 +1,7 @@
{
"scripts": {
"start": "npm i && tsc -v && npm start --workspaces",
"stop": "rm -rf packages/*/node_modules packages/*/dist packages/*/types packages/*/examples/*.tgz node_modules package-lock.json docs",
"stop": "rm -rf packages/*/node_modules packages/*/dist packages/*/types packages/*/examples/*.tgz packages/*/examples/node_modules packages/*/examples/package-lock.json node_modules package-lock.json docs",
"docs": "typedoc --version && typedoc"
},
"workspaces": [
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I tried to remove the forced build order here, but realized it's still necessary. That's because let's say I update smath to 1.9.2. Then, I update my other packages to use smath 1.9.2 as their dependency. Now, both smath, and the dependency have the same version number. That means npm is going to link them. And we already know, if they're linked, the dependency better be built before npm gets to the dependent package.

@nicfv nicfv mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm/t6 About the t6 package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant