-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update t6 to v1.1.7 #129
Update t6 to v1.1.7 #129
Conversation
@@ -1,3 +1,3 @@ | |||
#!/usr/bin/env bash | |||
|
|||
rm -rf dist types && tsc && node dist/test.js && rm dist/test.js types/test.d.ts && npm pack --pack-destination examples | |||
rm -rf dist types && tsc && node dist/test.js && rm dist/test.js types/test.d.ts && npm pack --pack-destination examples && cd examples && npm i |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually uncovered another issue... when I pack things that are dependent on versions that are currently being developed (e.g. not on npm
registry) the examples can't find those sub dependencies.
I'm almost feeling like idea If I do a major update on |
@@ -1,7 +1,7 @@ | |||
{ | |||
"scripts": { | |||
"start": "npm i && tsc -v && npm start --workspaces", | |||
"stop": "rm -rf packages/*/node_modules packages/*/dist packages/*/types packages/*/examples/*.tgz node_modules package-lock.json docs", | |||
"stop": "rm -rf packages/*/node_modules packages/*/dist packages/*/types packages/*/examples/*.tgz packages/*/examples/node_modules packages/*/examples/package-lock.json node_modules package-lock.json docs", | |||
"docs": "typedoc --version && typedoc" | |||
}, | |||
"workspaces": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: I tried to remove the forced build order here, but realized it's still necessary. That's because let's say I update smath to 1.9.2. Then, I update my other packages to use smath 1.9.2 as their dependency. Now, both smath, and the dependency have the same version number. That means npm
is going to link them. And we already know, if they're linked, the dependency better be built before npm
gets to the dependent package.
I opened this question that would make things easier for me if there was a solution:
https://stackoverflow.com/questions/79256829/how-to-use-version-range-syntax-for-locally-installed-packages
I'm not counting on it, though. This is the next best thing since it will fail immediately.