fixes #23223; prevents insert self-assignment (#23225)

fixes #23223 (cherry picked from commit 3379d26)
nim-lang · Apr 20, 2024 · 3b5eaea · 3b5eaea
1 parent eda7db1
commit 3b5eaea
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/system.nim b/lib/system.nim
@@ -2426,6 +2426,8 @@ when hasAlloc or defined(nimscript):
     ##   var a = "abc"
     ##   a.insert("zz", 0) # a <- "zzabc"
     ##   ```
+    if item.len == 0: # prevents self-assignment
+      return
     var xl = x.len
     setLen(x, xl+item.len)
     var j = xl-1

diff --git a/tests/system/tsystem_misc.nim b/tests/system/tsystem_misc.nim
@@ -212,3 +212,10 @@ block:
   doAssert not compiles(echo p.rawProc.repr)
   doAssert not compiles(echo p.rawEnv.repr)
   doAssert not compiles(echo p.finished)
+
+proc bug23223 = # bug #23223
+  var stuff = "hello"
+  stuff.insert ""
+  doAssert stuff == "hello"
+
+bug23223()