fixes #19401; fixes #19402; rework Forward declaration and finalizer …

…for ORC

compiler/semmagic.nim

@@ -535,7 +535,15 @@ proc magicsAfterOverloadResolution(c: PContext, n: PNode,
             getAttachedOp(c.graph, t, attachedDestructor).owner == fin:
           discard "already turned this one into a finalizer"
         else:
-          bindTypeHook(c, turnFinalizerIntoDestructor(c, fin, n.info), n, attachedDestructor)
+          if sfForward in fin.flags:
+            # todo change the name
+            let wrapperSym = newSym(skProc, getIdent(c.graph.cache, "wrapper_" & fin.name.s), nextSymId c.idgen, fin.owner, fin.info)
+            let wrapper = c.semExpr(c, newProcNode(nkProcDef, fin.info, body = newTree(nkCall, newSymNode(fin), fin.ast[paramsPos][1][0]),
+              params = fin.ast[paramsPos], name = newSymNode(wrapperSym), pattern = c.graph.emptyNode,
+              genericParams = c.graph.emptyNode, pragmas = c.graph.emptyNode, exceptions = c.graph.emptyNode), {})
+            bindTypeHook(c, turnFinalizerIntoDestructor(c, wrapperSym, wrapper.info), n, attachedDestructor)
+          else:
+            bindTypeHook(c, turnFinalizerIntoDestructor(c, fin, n.info), n, attachedDestructor)
     result = n
   of mDestroy:
     result = n

tests/arc/t19401.nim

@@ -0,0 +1,13 @@
+discard """
+  output: "delete foo"
+  matrix: "--mm:arc"
+"""
+
+type Foo = ref object
+proc delete(self: Foo) 
+proc newFoo: Foo = new(result, delete)
+proc delete(self: Foo) = echo("delete Foo")
+
+if isMainModule:
+  proc test() = discard newFoo()
+  test()

tests/arc/t19402.nim

@@ -0,0 +1,13 @@
+discard """
+  output: "delete foo"
+  matrix: "--mm:arc"
+"""
+
+type Foo = ref object of RootObj
+proc delete(self: Foo) 
+proc newFoo: Foo = new(result, delete)
+proc delete(self: Foo) = echo("delete Foo")
+
+if isMainModule:
+  proc test() = discard newFoo()
+  test()