sharedlists/sharedtables modules need threads option #18185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7ef364a.
|
std/sharedtables should still work without --threads:on, and |
|
So what about rlocks module, it is very inconsistent. locks doesn't require threads options So a module cannot switch from lock to rlock or add rlock support easily. |
maybe that's what should be fixed? I can look into it more tmrw if needed |
ringabout
added a commit
to ringabout/Nim
that referenced
this pull request
Jun 7, 2021
Merged
Araq
pushed a commit
that referenced
this pull request
Jun 7, 2021
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
* Revert "add missing import to asynchttpserver's example" This reverts commit 7ef364a. * alternative to nim-lang#18185 * add std/mutexes * cvlose nim-lang#17696 * Revert "add std/mutexes" This reverts commit 69abc8b. * tiny * test * improve terminal docs * follow advice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #18206
Ref #12231
Ref #12330
It might break things(CI should tell us a bit about it). I'm thinking that using RLock in SharedTable object may help #18176. It that's true, we have to break things or think of other ways.