Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate htmlparser #22870

Merged
merged 4 commits into from
Oct 26, 2023
Merged

deprecate htmlparser #22870

merged 4 commits into from
Oct 26, 2023

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Oct 25, 2023 •
edited
Loading

ref #22848
see also https://github.com/nim-lang/htmlparser
will build the documentation later when everything else is settled

@ringabout ringabout mentioned this pull request Oct 25, 2023
Closed
Araq
Araq reviewed Oct 26, 2023
View reviewed changes
changelog.md Outdated Show resolved Hide resolved
Araq
Araq reviewed Oct 26, 2023
View reviewed changes
lib/pure/htmlparser.nim Outdated Show resolved Hide resolved
@Araq Araq merged commit 0e45b01 into devel Oct 26, 2023
4 checks passed
@Araq Araq deleted the ringabout-patch-8 branch October 26, 2023 11:07
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 0e45b01

Hint: mm: orc; opt: speed; options: -d:release
174726 lines; 13.810s; 770.207MiB peakmem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Araq left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ringabout @Araq