Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IndexDefect errors in httpclient on invalid/weird headers #22886

Merged
merged 6 commits into from Nov 1, 2023
Merged

Fix IndexDefect errors in httpclient on invalid/weird headers #22886

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3cee224
Fix `IndexDefect` errors in httpclient on invalid/weird headers
Oct 30, 2023
832813e
linei can't be larger than line.len
Oct 30, 2023
ac25e37
Fix the case of a multiline header value without a header, change err…
Oct 30, 2023
74c629d
Don't refuse headers with empty value
Oct 30, 2023
bad312c
Update comments from discussion
Oct 31, 2023
f3c5822
Update lib/pure/httpcore.nim
Araq Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/pure/httpclient.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,7 +911,9 @@ proc parseResponse(client: HttpClient | AsyncHttpClient,
if line.len == le: httpError("Invalid headers - no colon after header name")
inc(linei, le) # Skip the parsed header name
inc(linei) # Skip :
if linei == line.len: httpError("Invalid headers - no header value after colon")
# Here linei is smaller or equal to line.len, so the slice below should work fine
# If we want to enforce the HTTP spec later, do this:
#if linei == line.len: httpError("Invalid headers - no header value after colon")
This conversation was marked as resolved.
Show resolved Hide resolved
# Remember the header name for the possible multi-line header
lastHeaderName = name
result.headers.add(name, line[linei .. ^1].strip())
Expand Down
Loading