fixes #22926; Different type inferred when setting a default value fo… #22955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r an array field fixes #22926
because of global errors
Araq
reviewed
Nov 25, 2023
| @@ -241,6 +241,12 @@ proc fitDefaultNode(c: PContext, n: PNode): PType = | |||
| if n[^2].kind != nkEmpty: | |||
| if expectedType != nil and oldType != expectedType: | |||
| n[^1] = fitNodeConsiderViewType(c, expectedType, n[^1], n[^1].info) | |||
| annotateType(n[^1], expectedType, c.config) # infer types for default fields value | |||
There was a problem hiding this comment.
We don't do this anywhere else in the compiler.
There was a problem hiding this comment.
Well, changeType works as well. Could we use that here? Because semConstExpr didn't infer the type from expectedType.
|
Succeeded by #22999 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r an array field
fixes #22926