Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #23001; give a better warning for PtrToCstringConv #23005

Merged
merged 1 commit into from
Nov 30, 2023
Merged

fixes #23001; give a better warning for PtrToCstringConv #23005

merged 1 commit into from
Nov 30, 2023

Conversation

ringabout
Copy link
Member

fixes #23001

@Araq Araq merged commit 7ea5aaa into devel Nov 30, 2023
22 checks passed
@Araq Araq deleted the pr_ptr_cstring branch November 30, 2023 13:12
@github-actions GitHub Actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 7ea5aaa

Hint: mm: orc; opt: speed; options: -d:release
177271 lines; 7.501s; 767.203MiB peakmem

narimiran pushed a commit that referenced this pull request Apr 18, 2024
@ringabout @narimiran
fixes #23001; give a better warning for PtrToCstringConv (#23005)
c696ec9 
fixes #23001

(cherry picked from commit 7ea5aaa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem removing cstring unsafe conversion warning
2 participants
@ringabout @Araq