fixes #18073; fixes #14730; document notnil is only applied to local … #23084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Dec 16, 2023
| @@ -560,7 +560,8 @@ Not nil annotation | |||
| `{.experimental: "notnil".}`. | |||
|
|
|||
| All types for which `nil` is a valid value can be annotated with the | |||
| `not nil` annotation to exclude `nil` as a valid value: | |||
| `not nil` annotation to exclude `nil` as a valid value. Note that only local | |||
| symbols are checked. | |||
There was a problem hiding this comment.
But globals should be checked too.
There was a problem hiding this comment.
The trackProc function only tracks local symbols. Similarly as this case, the strictdef analysis is applied to local symbols. I suppose it's hard to analyze global symbols, which might be used in functions arbitrarily.
Globals are only checked by the direct illegal assignment if that is what you meant. I will rephrase it better.
Or I might miss something?
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…symbols
fixes #18073
fixes #14730