-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get(Option[T], var T): bool
procedure
#23261
Open
xTrayambak
wants to merge
14
commits into
nim-lang:devel
Choose a base branch
from
xTrayambak:devel
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
0e216b0
(add) add proc
xTrayambak 1d051c4
(rename) rename get(Option[T], var T) to unpack(...)
xTrayambak 55a298c
(fix) fix tests to use unpack instead of get
xTrayambak 1a8fd60
(fix) update runnableExamples
xTrayambak 2ea2a82
(add) add ?= keyword, make use instead of
xTrayambak 53c9194
(fix) variable name mismatch
xTrayambak e070324
(fix) yet another error
xTrayambak 4f09e51
(fix) just remove ?=
xTrayambak 7b2417a
(add) try to re-add ?= operator
xTrayambak f0b3665
(fix) tiny error
xTrayambak 9d7ee3c
(fix) use boolean returned by unpack()
xTrayambak 0382544
(fix) add proper runnable example
xTrayambak 6c8304b
(fix) compilation error with fusion
xTrayambak c935b20
(fix) fix ?= keyword
xTrayambak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -215,6 +215,34 @@ proc get*[T](self: Option[T], otherwise: T): T {.inline.} = | |||||||
else: | ||||||||
otherwise | ||||||||
|
||||||||
proc unpack*[T](self: Option[T], val: out T): bool {.inline.} = | ||||||||
## Unpacks the contents of the `Option` if there are any, and returns true. | ||||||||
## Otherwise, it simply returns false and sets the value to its default one. | ||||||||
runnableExamples: | ||||||||
var storage: int | ||||||||
|
||||||||
if some(1337).unpack(storage): | ||||||||
assert storage == 1337 | ||||||||
|
||||||||
if not self.isSome: | ||||||||
val = default(T) | ||||||||
false | ||||||||
else: | ||||||||
val = self.get() | ||||||||
true | ||||||||
|
||||||||
template `?=`*[T](x: untyped{ident}, self: Option[T]): bool = | ||||||||
## Unpacks the contents of the `Option` into a value name provided if there are any, and returns true. | ||||||||
## Otherwise, returns false and no value is created. | ||||||||
runnableExamples: | ||||||||
let container = some(1337) | ||||||||
var store: int | ||||||||
|
||||||||
if store ?= container: | ||||||||
assert x == 1337 | ||||||||
|
||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
unpack(self, x) | ||||||||
|
||||||||
proc get*[T](self: var Option[T]): var T {.inline.} = | ||||||||
## Returns the content of the `var Option` mutably. If it has no value, | ||||||||
## an `UnpackDefect` exception is raised. | ||||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you force-push this one? I'm not on my computer now.