Dollar sign within quotations fix

[e-perl-NOAA]

See issue #150.

A fix in rm_dollar_sign.R to change text()$text within quotes (which would normally throw an error because it converted it to text()[["text"]]) to text()[['text']] instead, thereby fixing the issue of multiple double quotes in a line.

Tested locally by using the r4ss function file (get_ss3_exe.r) that originally made me aware of this issue:
https://github.com/r4ss/r4ss/blob/bb679f422ef6aa9189fe99c14375bee00dab2fa1/R/get_ss3_exe.r#L87

To test via GitHub actions I reverted the fixed line in the main branch of r4ss which has curl::curl_version()[['ssl_version']] back to curl::curl_version()$ssl_version and then ran the updated rm_dollar_sign.R function and had a successful run here.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 72.72727% with 9 lines in your changes missing coverage. Please review.

Project coverage is 93.36%. Comparing base (499d1d5) to head (58c37b3).

Files with missing lines	Patch %	Lines
R/rm_dollar_sign.R	72.72%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   95.19%   93.36%   -1.83%     
==========================================
  Files           4        4              
  Lines         208      226      +18     
==========================================
+ Hits          198      211      +13     
- Misses         10       15       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[k-doering-NOAA]

Thanks so much @e-perl-NOAA!! Working on reviewing this now!

[k-doering-NOAA]

Thanks so much @e-perl-NOAA, this is a great fix!!! I added a test to test that to make sure it works and it does!

However, I did realized we didn't account for nested lists in quotes, e.g., "list$item1$item2 in quotes", so I added some additional code; could you see if that looks good to you (I did add a test for this scenariom too)? If it looks good, I think we can merge this in!

[e-perl-NOAA]

Just tested the nested portion locally and it works for me!

[e-perl-NOAA]

I'll let you merge it in!