Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing to individual time step outputs for NetCDF files. #129

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

drnimbusrain
Copy link
Member

@drnimbusrain drnimbusrain commented Mar 22, 2024

@MaggieMarvin To avoid outputting to an overly large NetCDF output file in canopy-app, I decided to just change it to similarly how the text files work. Now, here by default, canopy-app will output separate NetCDF files for each timestep (e.g., hourly) with the output timestep stamp on the filenames. Its not the prettiest right now, but this should further facilitate testing longer biogenic simulations instead of having a single huge file. Please have a close look and make sure the outputs look good.

@drnimbusrain drnimbusrain added the enhancement New feature or request label Mar 22, 2024
Copy link
Collaborator

@MaggieMarvin MaggieMarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this works as expected - for the standard test case that is provided with canopy-app, this generates three output files, each containing the information expected for that time step t00*. This will definitely help with file size and is great for now! I'm not sure how easy it would be but at some point later I think it would help to change the output file naming convention from t00* to the corresponding time stamp if possible.

@drnimbusrain
Copy link
Member Author

Confirmed that this works as expected - for the standard test case that is provided with canopy-app, this generates three output files, each containing the information expected for that time step t00*. This will definitely help with file size and is great for now! I'm not sure how easy it would be but at some point later I think it would help to change the output file naming convention from t00* to the corresponding time stamp if possible.

@MaggieMarvin I agree with you. I have now changed both NCF and TXT outputs to instead append the valid time stamp to the output files now. Can you please check?

@MaggieMarvin
Copy link
Collaborator

Yes that works as expected, thank you!

@drnimbusrain drnimbusrain merged commit 8bef605 into develop Mar 23, 2024
4 checks passed
@drnimbusrain drnimbusrain deleted the hourly_output branch March 23, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants