Fix regression while using localdocs with server API. #3410
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cebtenzzre
approved these changes
Jan 23, 2025
Signed-off-by: Adam Treat <[email protected]>
Signed-off-by: Adam Treat <[email protected]>
manyoso
force-pushed
the
localdocs_server_api_fix
branch
from
770f68c to
d0a2b42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had a regression since 3.5.x where the model was not using localdocs for N > 1 server api message. We weren't taking into account the idiosyncratic way the server uses the chatmodel so that we require an offset when updating the sources.