Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Apache-2.0 in pyproject.toml #976

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

dgarros
Copy link
Contributor

@dgarros dgarros commented Nov 11, 2024

I think this should fix the issue in Pypi reported by #975

https://python-poetry.org/docs/pyproject/#license

@ktbyers
Copy link
Collaborator

ktbyers commented Nov 11, 2024

@dgarros Can you also switch the classifier to:

License :: OSI Approved :: Apache Software License 2.0 (Apache-2.0)

In pyproject.toml

See:

pypa/trove-classifiers#17

@dgarros
Copy link
Contributor Author

dgarros commented Nov 11, 2024

@dgarros Can you also switch the classifier to:

License :: OSI Approved :: Apache Software License 2.0 (Apache-2.0)

Done

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11785246387

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.813%

Totals Coverage Status
Change from base Build 11007727464: 0.0%
Covered Lines: 542
Relevant Lines: 954

💛 - Coveralls

@ktbyers ktbyers merged commit 9380759 into nornir-automation:main Nov 11, 2024
16 checks passed
@ktbyers
Copy link
Collaborator

ktbyers commented Jan 5, 2025

FYI, the second part of this didn't work i.e. pypi rejected it:

WARNING  Error during upload. Retry with the --verbose option for more details.                                                     
ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/                                                            
         'License :: OSI Approved :: Apache Software License 2.0 (Apache-2.0)' is not a valid classifier. See                       
         https://packaging.python.org/specifications/core-metadata for more information.

Also the classifier never accepted the change that was in the referenced issue (see):

https://github.com/pypa/trove-classifiers/blob/main/src/trove_classifiers/__init__.py#L283

So I am going to revert this part of the PR.

@ktbyers
Copy link
Collaborator

ktbyers commented Jan 5, 2025

I checked both the METADATA file and the PKG-INFO file and the Properietary License referfence was gone (after reverting the classifier part of this.

So adding the hyphen was sufficient to fix the original issue.

@ktbyers ktbyers mentioned this pull request Jan 5, 2025
@ktbyers
Copy link
Collaborator

ktbyers commented Jan 6, 2025

@dbarrosop @ogenstad Should be a quick review/approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants