Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove repeated blob command #1152

Closed
wants to merge 1 commit into from
Closed

fix: remove repeated blob command #1152

wants to merge 1 commit into from

Conversation

JeyJeyGao
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.29%. Comparing base (61bef0f) to head (36bfe56).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1152      +/-   ##
==========================================
- Coverage   73.30%   73.29%   -0.01%     
==========================================
  Files          53       53              
  Lines        3240     3239       -1     
==========================================
- Hits         2375     2374       -1     
  Misses        671      671              
  Partials      194      194

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shizhMSFT
shizhMSFT approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Two-Hearts
Two-Hearts reviewed Jan 21, 2025
View reviewed changes
cmd/notation/main.go
@@ -52,7 +52,6 @@ func main() {
},
}
cmd.AddCommand(
blob.Cmd(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix should be in PR: #1133, please have the fix there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a minor fix. Either way is fine. Let's fix it in #1133.

@Two-Hearts Two-Hearts mentioned this pull request Jan 21, 2025
Draft
Two-Hearts
Two-Hearts requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually seeing this #1133 (comment) in #1133.

@JeyJeyGao
Copy link
Contributor Author

As discussed with @Two-Hearts . I will include the fix in #1133

@JeyJeyGao JeyJeyGao closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Two-Hearts Two-Hearts Two-Hearts requested changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@priteshbandi priteshbandi Awaiting requested review from priteshbandi priteshbandi is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeyJeyGao @shizhMSFT @Two-Hearts