Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for text with and without attributes #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olzzon
Copy link
Contributor

@olzzon olzzon commented Jan 7, 2025

About the Contributor

This PR is made on behalf of BBC

Type of Contribution

This is a test case improvement

Current Behavior

Prior to latest update bbc had an issue where single path text field with attributes wasn't parsed:
e.g. <variable name="locations">1,2,3,4</variable>
This seems to have been fixed in latest update.

New Behavior

To ensure this not to happen in future changes this test case has been added.

Testing Instructions

Run the tests.

Other Information

There are no functional changes in this PR, and if this is already covered in some other test, we can just close this PR.

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.12%. Comparing base (64771f5) to head (ece22e4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   75.97%   76.12%   +0.14%     
==========================================
  Files          68       68              
  Lines        4016     4016              
  Branches      920      929       +9     
==========================================
+ Hits         3051     3057       +6     
+ Misses        964      958       -6     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olzzon olzzon marked this pull request as ready for review January 9, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants