NNS update for 0.20.0 #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna Shaleva <[email protected]>
Signed-off-by: Anna Shaleva <[email protected]>
Signed-off-by: Anna Shaleva <[email protected]>
Reuse getAllRecords for GetAllRecords. Signed-off-by: Anna Shaleva <[email protected]>
Do not include CNAME to the resulting list if we're looking for another record type. If it's CNAME than it must be resolved. Signed-off-by: Anna Shaleva <[email protected]>
Do not move parts of SetRecord/AddRecord to a separate functions, it makes the contract code more complicated. Also, improve documentation a bit. Signed-off-by: Anna Shaleva <[email protected]>
a.b.c.d can be an "a.b" record of "c.d" and can be "a" record of "b.c.d", the first one would fail to setRecord currently: at instruction 4287 (THROW): unhandled exception: "parent domain has expired" which is a 5758c84 regression. Signed-off-by: Roman Khimov <[email protected]>
Don't repeat it each time. Signed-off-by: Anna Shaleva <[email protected]>
It doesn't save VM opcodes, but allows to keep record key creation logic in a single place which prevents the code from bugs appearance. Signed-off-by: Anna Shaleva <[email protected]>
Less code repeating. Signed-off-by: Anna Shaleva <[email protected]>
Signed-off-by: Anna Shaleva <[email protected]>
Signed-off-by: Anna Shaleva <[email protected]>
If conflicting records '*.domain' are present on new domain registration, then `isAvailable` should return false for this domain. Ref. f25296b. Signed-off-by: Anna Shaleva <[email protected]>
Signed-off-by: Anna Shaleva <[email protected]>
Merged
roman-khimov
force-pushed
the
nns-upd-0.20.0
branch
2 times, most recently
from
d0d687a to
405162e
Compare
carpawell
previously approved these changes
Jul 29, 2024
contracts/nns/contract.go
Outdated
| @@ -60,7 +60,7 @@ const ( | |||
| maxTXTRecordLength = 255 | |||
| // maxRecordID is the maximum value of record ID (the upper bound for the number | |||
| // of records with the same type). | |||
| maxRecordID = 255 | |||
| maxRecordID = 16 | |||
There was a problem hiding this comment.
do we have some ref why this number is good? is it your idea? is it from some original version of NNS?
There was a problem hiding this comment.
No. Yes. No. We definitely need to fix ID overflow problem, but using a lot of records can be a problem performance-wise (likely signifying some design issues). So start small, extend if needed.
These numbers are pretty much arbitrary, but we currently don't need more than that. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
nns-upd-0.20.0
branch
from
efd3137 to
22be33c
Compare
Part of #411. Signed-off-by: Roman Khimov <[email protected]>
1. splitAndCheck doesn't need allowMultipleFragments since there is exactly one user of it and it checks for the number of fragments anyway. 2. We can panic right inside of it with a bit more details, nil fragments are never valid. 3. Except for one case in checkRecord where the error must be different, so safeSplitAndCheck is introduced. Fixes #411. Signed-off-by: Roman Khimov <[email protected]>
cthulhu-rider
previously approved these changes
Jul 30, 2024
Sometimes 10 is exactly the value, so changing it doesn't make the ID different:
Error Trace: /home/runner/go/pkg/mod/github.com/nspcc-dev/[email protected]/pkg/neotest/basic.go:218
/home/runner/go/pkg/mod/github.com/nspcc-dev/[email protected]/pkg/neotest/client.go:108
/home/runner/work/neofs-contract/neofs-contract/tests/container_test.go:237
Error: Not equal:
expected: 0x1
actual : 0x2
Test: TestContainerPut/standard_deploy/with_nice_names/register_in_advance
Messages: at instruction 2149 (THROW): unhandled exception: "container was previously deleted"
Signed-off-by: Roman Khimov <[email protected]>
cthulhu-rider
approved these changes
Jul 30, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a rebase of #266 with two additional commits.