node/object: Fix Put op condition checking requests with copies number

Regression from 5076fe2. Previously, the operation always failed on in-container nodes for requests with specified number of copies. Actually, it must fail requests with TTL=1 regardless of container composition. Signed-off-by: Leonard Lyubich <[email protected]>
nspcc-dev · Dec 4, 2024 · 5a972a4 · 5a972a4
1 parent f831c75
commit 5a972a4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@ Changelog for NeoFS Node
 
 ### Fixed
 - Fail gracefully on error from config validation (#3037)
+- False-negative object PUT from container node with set copies number (#3042)
 
 ### Changed
 

diff --git a/pkg/services/object/put/streamer.go b/pkg/services/object/put/streamer.go
@@ -140,6 +140,10 @@ func (p *Streamer) initTarget(prm *PutInitPrm) error {
 }
 
 func (p *Streamer) preparePrm(prm *PutInitPrm) error {
+	localOnly := prm.common.LocalOnly()
+	if localOnly && prm.copiesNumber > 0 {
+		return errors.New("storage of multiple object replicas is requested for a local operation")
+	}
 	var err error
 
 	localNodeKey, err := p.keyStorage.GetKey(nil)
@@ -170,15 +174,12 @@ nextSet:
 		for j := range cnrNodes[i] {
 			prm.localNodeInContainer = p.neoFSNet.IsLocalNodePublicKey(cnrNodes[i][j].PublicKey())
 			if prm.localNodeInContainer {
-				if prm.copiesNumber > 0 {
-					return errors.New("storage of multiple object replicas is requested for a local operation")
-				}
 				prm.localNodePos[0], prm.localNodePos[1] = i, j
 				break nextSet
 			}
 		}
 	}
-	if !prm.localNodeInContainer && prm.common.LocalOnly() {
+	if !prm.localNodeInContainer && localOnly {
 		return errors.New("local operation on the node not compliant with the container storage policy")
 	}