Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on macOS #21

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Build on macOS #21

merged 2 commits into from
Sep 3, 2024

Conversation

ntBre
Copy link
Owner

@ntBre ntBre commented Aug 27, 2024

Should fix #20 eventually

ntBre and others added 2 commits August 27, 2024 15:25
the struct doesn't have this field on mac:
https://docs.rs/libc/latest/x86_64-apple-darwin/libc/struct.sigaction.html

fortunately, we just set it to None here anyway, even on linux
@moonstripe
Copy link

Now "works" on XQuartz.

Still need to play around and change the mod key (conflict with mac world). Will write some docs.

Copy link

@moonstripe moonstripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed enables building to macOS!

@ntBre ntBre merged commit f93c680 into master Sep 3, 2024
6 checks passed
@ntBre ntBre deleted the macos-build branch September 3, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Trying to Compile on MacOS (x86_64)
2 participants