STUN: major code rework #2116
Merged
STUN: major code rework #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanNardi
force-pushed
the
stun_cache_confidence
branch
3 times, most recently
from
6f27d81 to
27d9108
Compare
|
Quite a rough change to stun, will take some time to review. :) |
Try to have a faster classification, on first packet; use standard extra dissection data path for sub-classification, metadata extraction and monitoring. STUN caches: * use the proper confidence value * lookup into the caches only once per flow, after having found a proper STUN classification Add identification of Telegram VoIP calls.
IvanNardi
force-pushed
the
stun_cache_confidence
branch
from
27d9108 to
49d9053
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Looks good to me. Let's wait for @utoni |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to have a faster classification, on first packet; use standard extra dissection data path for sub-classification, metadata extraction and monitoring.
STUN caches:
Add identification of Telegram VoIP calls.