Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: container-type level version compatibility check #94

Merged
merged 8 commits into from
Oct 1, 2024

Conversation

KeranYang
Copy link
Member

No description provided.

@KeranYang KeranYang marked this pull request as ready for review October 1, 2024 15:24
@KeranYang KeranYang requested review from vigith, kohlisid and yhl25 October 1, 2024 15:24
Cargo.toml Outdated Show resolved Hide resolved
Signed-off-by: Keran Yang <[email protected]>
@KeranYang KeranYang requested a review from vigith October 1, 2024 16:08
@vigith
Copy link
Member

vigith commented Oct 1, 2024

why not use the std's OnceCell https://doc.rust-lang.org/std/cell/struct.OnceCell.html

.
Signed-off-by: Keran Yang <[email protected]>
.
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
.
Signed-off-by: Keran Yang <[email protected]>
@KeranYang KeranYang merged commit 36ad0a7 into numaproj:main Oct 1, 2024
2 checks passed
@KeranYang KeranYang deleted the container-version branch October 1, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants