feat: version compatibility check for MonoVertex #1912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sidhant Kohli <[email protected]>
vigith
changed the title
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
yhl25
reviewed
Aug 9, 2024
| /// Struct to hold version information | ||
| #[derive(Debug)] | ||
| pub struct VersionInfo { | ||
| pub version: String, |
There was a problem hiding this comment.
Do we really need all these information?
Comment on lines
+234
to
+244
| // Retry limit logic | ||
| retry += 1; | ||
| if retry >= 10 { | ||
| // Return an error if the retry limit is reached | ||
| return Err(Error::ServerInfoError( | ||
| "server-info reading retry exceeded".to_string(), | ||
| )); | ||
| } | ||
| sleep(Duration::from_millis(100)).await; // Sleep before retrying | ||
| } | ||
|
|
vigith
reviewed
Aug 9, 2024
|
|
||
| pub mod server_info; | ||
|
|
||
| pub mod version; |
There was a problem hiding this comment.
these need not be pub also mod version should be inside server_info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1908