-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs and flake #289
Conversation
so that they appear in the top of a devshell message
- use message from the default devShell - fix headings - write about new scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost ready
@@ -2,10 +2,12 @@ | |||
authors = ["zimbatm"] | |||
language = "en" | |||
multilingual = false | |||
src = "." | |||
src = "src" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the motivation for moving this one level down? It's one more level to traverse when navigating the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This structure is described in the mdbook docs
flake.nix
Outdated
path = ./templates/flake-parts; | ||
description = "nix flake new my-project -t github:numtide/devshell#flake-parts"; | ||
# nix flake update --recreate-lock-file | ||
inputs.nixpkgs.url = "github:NixOS/nixpkgs/efc960b6d6a6498c23868f4ba59fcb8bb51c9861"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you point to a channel instead, to make it easier to bump nixpkgs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in bd708b4
the --recreate-lock-file flag is marked as deprecated in the nix docs https://nixos.org/manual/nix/unstable/command-ref/new-cli/nix3-flake-update#opt-recreate-lock-file
thanks! |
Before this change it was possible to use the devshell flake without overlays (#162, #165): devshell.inputs.nixpkgs.follows = "nixpkgs"; devShells.default = inputs.devshell.legacyPackages.${system}.mkShell {
# ... configuration ...
}; But this PR removed The following works, but looks like a hack due to the non-flake import (and the devshell = import inputs.devshell {
inherit system;
inputs = null;
nixpkgs = inputs.nixpkgs.legacyPackages.${system};
}; devShells.default = devshell.mkShell {
# ... configuration ...
}; Is migrating to flake-parts the only supported way forward? |
Thank you! It's a regression. The only way is to restore |
root = ./.; | ||
fileset = fs.unions [ | ||
(fs.fileFilter (file: file.hasExt "md") ./src) | ||
(fs.fileFilter (file: true) ./theme) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh just randomly seeing this: There's no need to use fileFilter
when you want to include every file of a directory, ./theme
by itself is also coerced to a file set to contain all its files :)
(fs.fileFilter (file: true) ./theme) | |
./theme |
Previously: part of #288