[Ion::Keyboard::scan] Added some scancode #1616

RedGl0w · 2020-07-11T10:18:47Z

This is very usefull with Ion module of mpy port. Some keys aren't mapped, because they don't exist at simulator's host's keyboard (ex : sin, pi, sqrt, ...)
It fixes #1555 and #1678

The text was iffset due to the subtitle rows

Not just after adding or deleting text

Because some functions already have the parentheses in their name, so their type would have been Variable but it is clearer to give it the type WithoutParentheses. this is the case for nodes created from toolbox nodes.

Scenario: write i, open the varbox and select "in" -> parentheses are added, but there shouldn't be any

Reverts 39c3d66cd

Not at the end of "words" separated by spaces.

For instance, type "abs", there is "()" autocompletion

That function is supposed to recompute the layout, not perform any drawing. Namely, presenting the render without a potential previous call to SDL_RenderClear could lead to some visual glitches.

We might be relayouting a bit too often, but better safe than sorry! Jokes aside, most SDL_WINDOWEVENT should trigger a relayout, and in general those events aren't triggered on a regular basis anyway.

Otherwise the .ipa cannot be uploaded to the app store.

Scenario: Put the complex mode to exponential, then go back to Calculation and: Toolbox, Down, Down, Down, Down, OK, OK, Two, Plus, Imaginary, Toolbox, Down, Down, Down, Down, OK, Down, OK, Two, Plus, Imaginary, OK, Toolbox, Down, Down, Down, Down, Down, OK, Down, OK, Up, OK, Right, Zero, OK, OK, Toolbox, Down, Down, OK, Toolbox, Back, Up, Zero, Up, OK, Zero, Up, Up, Up

If the last cell is too big to fit entirely, we would scroll to the top of the calculation, instead of the bottom

There was a problem with the way of computing Height, see Calculation::HistoryViewCell. We did not encounter a problemeatic scenario here, but there is no reason it would have been safe before.

When a library was broken, we would see an error due to the failed setWindowStyle call, instead of getting the briken library error.

NumWorksBot · 2020-07-11T10:23:55Z

	.text	.rodata	.bss	.data
Base	647 140 bytes	264 335 bytes	175 112 bytes	1 72 bytes
Head	647 140 bytes	264 335 bytes	175 112 bytes	1 72 bytes
	+ 0 bytes	+ 0 bytes	+ 0 bytes	+ 0 bytes
	+ 0 %	+ 0 %	+ 0 %	+ 0 %

See numworks#1678 (comment)

NumWorksBot · 2020-10-17T09:09:51Z

	.text	.rodata	.bss	.data
Base	647 140 bytes	264 335 bytes	175 112 bytes	1 72 bytes
Head	647 140 bytes	264 335 bytes	175 112 bytes	1 72 bytes
	+ 0 bytes	+ 0 bytes	+ 0 bytes	+ 0 bytes
	+ 0 %	+ 0 %	+ 0 %	+ 0 %

RedGl0w · 2021-02-23T10:37:25Z

ion/src/simulator/shared/keyboard_sdl.cpp

+  KeySDLKeyPair(Ion::Keyboard::Key::Zero,           SDL_SCANCODE_0),
+  KeySDLKeyPair(Ion::Keyboard::Key::Dot,            SDL_SCANCODE_KP_PERIOD),
+  KeySDLKeyPair(Ion::Keyboard::Key::Dot,            SDL_SCANCODE_PERIOD),
+  KeySDLKeyPair(Ion::Keyboard::Key::EXE,            SDL_SCANCODE_RETURN),


Maybe this could be changed to Ok,
So KP_ENTER is EXE and RETURN is OK ?

CLAassistant · 2021-11-19T15:31:07Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 6 committers have signed the CLA.

✅ LeaNumworks
✅ EmilieNumworks
✅ GabrielNumworks
✅ RedGl0w
✅ Ecco
❌ RobertaNumWorks
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

LeaNumworks added 30 commits June 4, 2020 14:50

[apps/code] Insert right text form var box

03471bb

The text was iffset due to the subtitle rows

[apps/code] Autocomplete when cursor at the end of the word

b41d1e3

Not just after adding or deleting text

[escher/stack_view_controller] Inline some methods

b3d87c0

[apps] AlternateEmptyNestedMenuController handles empty lists

3d64b8d

[apps/code] Add list methods to the variable box

74b786f

[apps/code] Rename ScriptNode::Types to With/WithoutParentheses

bbeb17c

Because some functions already have the parentheses in their name, so their type would have been Variable but it is clearer to give it the type WithoutParentheses. this is the case for nodes created from toolbox nodes.

[apps/code] Cosmetic fixes on the variable box

0d60161

[apps/code] Do not select subtitles in the variable box

33d8d10

[apps/code] Fix assertion

f371126

[apps/variable_box] Prepare for Code::VariableBox factorization

f98c171

[apps/code] Empty controller in the var box

398de8b

[apps/code] Display empty message in var box

0033176

[escher] Clean InputEventHandler

a165c6d

[apps/code] Add matplotlib.pyplot in the var box

5393ec7

[escher/text_field] Fix std::min use

0f2ac5b

[apps/code] Translate the variable box

dd6c2a4

[apps/code] Fix varbox that should autocomplete the current word

e73ae9b

[apps/code] Remove __import__ from builtins

e630b0e

[apps/code] Fix varbox parentheses bug

7636c00

Scenario: write i, open the varbox and select "in" -> parentheses are added, but there shouldn't be any

[apps/code] Change autocomplete color

4502ae4

[apps/code] Autocomplete only after edition

9bf361d

Reverts 39c3d66cd

[apps/code] Autocomplete at the end of tokens

da2730d

Not at the end of "words" separated by spaces.

[apps/code] Autocompletion end is end of token, not next ' '

2ed0c85

[apps/code] Add the parentheses in the autocompletion

5d29101

[apps/code] Autocomplete only with parentheses if needed

94e9a10

For instance, type "abs", there is "()" autocompletion

[apps/code] Use variable

e7bfb3b

[apps/code] Signed/unsigned comparison

afdf34b

[apps/code] Cycle through possible autocompletions with up/down

2a82341

[apps/code] Handle autocompletionAlternativeAtIndex with no nodes

f9bbc94

[apps/code] Fix PythonTextArea::autocompletionType

a777357

Ecco and others added 16 commits July 2, 2020 14:42

[ion/simulator] Ion::Simulator::Main::relayout() should not draw

7a99541

That function is supposed to recompute the layout, not perform any drawing. Namely, presenting the render without a potential previous call to SDL_RenderClear could lead to some visual glitches.

[ion/simulator] Relayout on any windows event

5dfccd4

We might be relayouting a bit too often, but better safe than sorry! Jokes aside, most SDL_WINDOWEVENT should trigger a relayout, and in general those events aren't triggered on a regular basis anyway.

[apps/regression] Fix wrong proportional model fit

6b60fc5

[escher] Fix constexpr due to linux warning

759fa6a

build: Version 14.3.0

38f3c9b

[ion/apple] App needs to be inside Payload folder to build .ipa

1ef3f34

Otherwise the .ipa cannot be uploaded to the app store.

[apps/calculation] Comment possible failed height computation

35f20c4

[apps/calculation] Factorize some code

924e235

[apps/calculation] Fix scrolling

982b467

If the last cell is too big to fit entirely, we would scroll to the top of the calculation, instead of the bottom

[apps/calculation] Apply fix about Height computation

cc4ff3d

There was a problem with the way of computing Height, see Calculation::HistoryViewCell. We did not encounter a problemeatic scenario here, but there is no reason it would have been safe before.

[apps/calculation] Add TODO comments about factorization

d8f17da

build: Version 14.4.0

ef8a4f9

[ion/android] Do not setWindowStyle if SDL not initialized

1fde815

When a library was broken, we would see an error due to the failed setWindowStyle call, instead of getting the briken library error.

[build/android] Prevent code relocations in MicroPython

2af89fb

[Ion::Keyboard::scan] Added some scancode

d0a79c2

LeaNumworks assigned artaxxx Sep 3, 2020

RedGl0w mentioned this pull request Oct 12, 2020

App does not capture KP_Enter. #1678

Open

[Ion::Keyboard] Added KP_Enter as scan code

b0a9823

See numworks#1678 (comment)

RedGl0w mentioned this pull request Feb 22, 2021

[bug] [simulator/shared] Fix numeric enter key #1788

Closed

RedGl0w commented Feb 23, 2021

View reviewed changes

EmilieNumworks force-pushed the master branch from 8cfa1d7 to 7bab48b Compare August 20, 2021 12:30

EmilieNumworks force-pushed the master branch 2 times, most recently from e385767 to 974bf08 Compare December 1, 2021 16:37

EmilieNumworks force-pushed the master branch from 7c15e2e to e82884b Compare August 23, 2022 14:47

EmilieNumworks force-pushed the master branch from bb3baa7 to e4c3a98 Compare February 2, 2023 11:08

HugoNumworks force-pushed the master branch from 117eea7 to 35a8a17 Compare July 11, 2024 14:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Ion::Keyboard::scan] Added some scancode #1616

[Ion::Keyboard::scan] Added some scancode #1616

RedGl0w commented Jul 11, 2020 •

edited

Loading

NumWorksBot commented Jul 11, 2020

NumWorksBot commented Oct 17, 2020

RedGl0w Feb 23, 2021

CLAassistant commented Nov 19, 2021 •

edited

Loading

[Ion::Keyboard::scan] Added some scancode #1616

Are you sure you want to change the base?

[Ion::Keyboard::scan] Added some scancode #1616

Conversation

RedGl0w commented Jul 11, 2020 • edited Loading

NumWorksBot commented Jul 11, 2020

NumWorksBot commented Oct 17, 2020

RedGl0w Feb 23, 2021

Choose a reason for hiding this comment

CLAassistant commented Nov 19, 2021 • edited Loading

RedGl0w commented Jul 11, 2020 •

edited

Loading

CLAassistant commented Nov 19, 2021 •

edited

Loading