Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPY] Enabled help #1619

Open
wants to merge 9,410 commits into
base: master
Choose a base branch
from
Open

[MPY] Enabled help #1619

wants to merge 9,410 commits into from

Conversation

RedGl0w
Copy link
Contributor

@RedGl0w RedGl0w commented Jul 12, 2020

This PR enable help() function in mpy

Todo

  • Add a small text message like :
[GCC 10.1.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

when starting the console (but not when executing a script)

  • Add help on modules

The text was iffset due to the subtitle rows
Because some functions already have the parentheses in their name, so
their type would have been Variable but it is clearer to give it the
type WithoutParentheses. this is the case for nodes created from toolbox
nodes.
Scenario: write i, open the varbox and select "in" -> parentheses are
added, but there shouldn't be any
Not at the end of "words" separated by spaces.
For instance, type "abs", there is "()" autocompletion
GabrielNumworks and others added 21 commits June 30, 2020 15:41
Fixed a bug involving mishandled negative offsets in
CalculationSelectableTableView::scrollToSubviewOfTypeOfCellAtLocation
and cleaned up the function.

Change-Id: I4394ca9dc9748e8b761e7f722e41014d71d3373f
That function is supposed to recompute the layout, not perform any
drawing. Namely, presenting the render without a potential previous call
to SDL_RenderClear could lead to some visual glitches.
We might be relayouting a bit too often, but better safe than sorry!
Jokes aside, most SDL_WINDOWEVENT should trigger a relayout, and in
general those events aren't triggered on a regular basis anyway.
Otherwise the .ipa cannot be uploaded to the app store.
Scenario:
Put the complex mode to exponential, then go back to Calculation and:
Toolbox, Down, Down, Down, Down, OK, OK, Two, Plus, Imaginary,
Toolbox, Down, Down, Down, Down, OK, Down, OK, Two, Plus,
Imaginary, OK, Toolbox, Down, Down, Down, Down, Down, OK,
Down, OK, Up, OK, Right, Zero, OK, OK, Toolbox, Down,
Down, OK, Toolbox, Back, Up, Zero, Up, OK, Zero, Up, Up, Up
If the last cell is too big to fit entirely, we would scroll to the top
of the calculation, instead of the bottom
There was a problem with the way of computing Height, see
Calculation::HistoryViewCell. We did not encounter a problemeatic
scenario here, but there is no reason it would have been safe before.
When a library was broken, we would see an error due to the failed
setWindowStyle call, instead of getting the briken library error.
@NumWorksBot
Copy link

.text .rodata .bss .data
Base 647 140 bytes 264 335 bytes 175 112 bytes 1 72 bytes
Head 647 340 bytes 264 423 bytes 175 112 bytes 1 72 bytes
+ 200 bytes + 88 bytes + 0 bytes + 0 bytes
+ 0 % + 0 % + 0 % + 0 %

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 6 committers have signed the CLA.

✅ EmilieNumworks
✅ Ecco
✅ RedGl0w
✅ GabrielNumworks
✅ LeaNumworks
❌ RobertaNumWorks
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants